-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: remove unsafe std::env::set_var
#228
Conversation
…rate::procedure`
51a6037
to
c021279
Compare
@race-of-sloths ping |
@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 13! We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
…ption<ImplicitEnvOpts> `build` arg
581b30b
to
c8e8910
Compare
d9abdcc
to
db9ae5c
Compare
@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: waiting for scoringWe're waiting for maintainer to score this pull request with What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
b77608a
to
04e64a8
Compare
"dep:url", "dep:serde", "dep:git2", | ||
"dep:home", "dep:pathdiff", "dep:unix_path", | ||
"dep:tempfile", "dep:nix", "dep:shell-words" | ||
"dep:url", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fmt applied with https://taplo.tamasfe.dev/
190c7c3
to
b982e74
Compare
e90b48a
to
42e48bf
Compare
manual addition of `no_wasmopt` to docker::DockerBuildOpts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@race-of-sloths score 13
api example for build scripts - build.rs
this has been extensively tested on following cases:
sample-crate
https://github.com/dj8yfo/sample_no_workspace/tree/test_remove_unsafe_env_set_var-no-docker => sample-crate-104.testnet
https://github.com/dj8yfo/sample_no_workspace/tree/32b06ab1be4bfd49cf54e6cda4e9d8481215195b => sample-crate-105.testnet
factory-rust
ok (same bs / image) https://github.com/dj8yfo/factory-rust/tree/c5a970b4fb9436d2d9009035edbd1017e7f31a87 => repro-fct-76.testnet , ...
fail (new bs / old image) https://github.com/dj8yfo/factory-rust/tree/f3b9c74d4d759c32274554d598c5c91310e0bf47 => repro-fct-77.testnet , ...
fails reproducibility verification, across breaking change boundary (builder version
cargo-near-build 0.2.0
-> builder environment version0.6.4
)fail (old bs / new image) https://github.com/dj8yfo/factory-rust/tree/386f8ce9e0d7c8afcc931afb6dc64d564870adaf => repro-fct-78.testnet , ...
fails reproducibility verification, across breaking change boundary (builder version
cargo-near-build 0.1.0
-> builder environment versioncargo-near-build 0.2.0
)neardevhub
https://github.com/dj8yfo/neardevhub-contract/tree/e1882a5149168c38841205ecc8370529bf2d3ecb => community.devhub-unse.testnet
https://github.com/dj8yfo/neardevhub-contract/tree/e1882a5149168c38841205ecc8370529bf2d3ecb => community.devhub-unsf.testnet