Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove unsafe std::env::set_var #228

Merged
merged 32 commits into from
Oct 18, 2024

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Sep 27, 2024

api example for build scripts - build.rs

this has been extensively tested on following cases:

sample-crate

  1. https://github.com/dj8yfo/sample_no_workspace/tree/test_remove_unsafe_env_set_var-no-docker => sample-crate-104.testnet

  2. https://github.com/dj8yfo/sample_no_workspace/tree/32b06ab1be4bfd49cf54e6cda4e9d8481215195b => sample-crate-105.testnet

factory-rust

  1. ok (same bs / image) https://github.com/dj8yfo/factory-rust/tree/c5a970b4fb9436d2d9009035edbd1017e7f31a87 => repro-fct-76.testnet , ...

  2. fail (new bs / old image) https://github.com/dj8yfo/factory-rust/tree/f3b9c74d4d759c32274554d598c5c91310e0bf47 => repro-fct-77.testnet , ...
    fails reproducibility verification, across breaking change boundary (builder version cargo-near-build 0.2.0 -> builder environment version 0.6.4)

  3. fail (old bs / new image) https://github.com/dj8yfo/factory-rust/tree/386f8ce9e0d7c8afcc931afb6dc64d564870adaf => repro-fct-78.testnet , ...
    fails reproducibility verification, across breaking change boundary (builder version cargo-near-build 0.1.0 -> builder environment version cargo-near-build 0.2.0)

neardevhub

  1. https://github.com/dj8yfo/neardevhub-contract/tree/e1882a5149168c38841205ecc8370529bf2d3ecb => community.devhub-unse.testnet

  2. https://github.com/dj8yfo/neardevhub-contract/tree/e1882a5149168c38841205ecc8370529bf2d3ecb => community.devhub-unsf.testnet

@dj8yfo dj8yfo force-pushed the remove_unsafe_std_env_set_var branch from 51a6037 to c021279 Compare September 27, 2024 19:40
@dj8yfo dj8yfo marked this pull request as ready for review September 27, 2024 21:05
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Sep 27, 2024

@race-of-sloths ping

@dj8yfo dj8yfo requested a review from frol September 27, 2024 21:06
@race-of-sloths
Copy link

race-of-sloths commented Sep 27, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 13

Your contribution is much appreciated with a final score of 13!
You have received 143 (130 base + 10% lifetime bonus) Sloth points for this contribution

We would appreciate your feedback or contribution idea that you can submit here

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo dj8yfo marked this pull request as draft September 30, 2024 17:26
@dj8yfo dj8yfo force-pushed the remove_unsafe_std_env_set_var branch 2 times, most recently from 581b30b to c8e8910 Compare October 2, 2024 19:23
@dj8yfo dj8yfo force-pushed the remove_unsafe_std_env_set_var branch 2 times, most recently from d9abdcc to db9ae5c Compare October 3, 2024 14:17
@race-of-sloths-bot
Copy link

race-of-sloths-bot commented Oct 4, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows profile picture for the author of the PR

Current status: waiting for scoring

We're waiting for maintainer to score this pull request with @race-of-sloths score [0,1,2,3,5,8,13] command. Alternatively, autoscoring [1,2] will be applied for this pull request

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo dj8yfo marked this pull request as ready for review October 4, 2024 19:14
cargo-near-build/src/near/build/mod.rs Outdated Show resolved Hide resolved
cargo-near-build/src/near/build_extended/mod.rs Outdated Show resolved Hide resolved
@dj8yfo dj8yfo marked this pull request as draft October 10, 2024 15:45
@dj8yfo dj8yfo force-pushed the remove_unsafe_std_env_set_var branch from b77608a to 04e64a8 Compare October 14, 2024 16:24
Cargo.lock Outdated Show resolved Hide resolved
"dep:url", "dep:serde", "dep:git2",
"dep:home", "dep:pathdiff", "dep:unix_path",
"dep:tempfile", "dep:nix", "dep:shell-words"
"dep:url",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt applied with https://taplo.tamasfe.dev/

@dj8yfo dj8yfo force-pushed the remove_unsafe_std_env_set_var branch 2 times, most recently from 190c7c3 to b982e74 Compare October 15, 2024 15:05
@dj8yfo dj8yfo force-pushed the remove_unsafe_std_env_set_var branch 3 times, most recently from e90b48a to 42e48bf Compare October 15, 2024 20:41
manual addition of `no_wasmopt` to docker::DockerBuildOpts
@dj8yfo dj8yfo marked this pull request as ready for review October 18, 2024 19:33
Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 13

@frol frol merged commit 634877a into near:main Oct 18, 2024
17 checks passed
@frol frol mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants