-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use Posthog instead of Mixpanel to collect stats on new projects creation #227
Conversation
@garikbesson Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 3! We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
cargo-near/src/posthog_tracking.rs
Outdated
pkg_version: env!("CARGO_PKG_VERSION").to_string(), | ||
let properties = PosthogProperties { | ||
language: "rs".to_string(), | ||
engine: version().unwrap().to_string(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no value in capturing Rust compiler version. We care about the cargo-near version, so please, see the previous version for CARGO_PKG_VERSION and remove rustc_version dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@garikbesson Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: waiting for finalizationThe pull request is merged, you have 24 hours to finalize your scoring. The scoring ends Thu Oct 10 11:52:11 2024
Your contribution is much appreciated with a final score of 3! What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@race-of-sloths-bot score 3
## 🤖 New release * `cargo-near`: 0.9.0 -> 0.10.0 (⚠️ API breaking changes) * `cargo-near-build`: 0.1.1 -> 0.2.0 (⚠️ API breaking changes) ###⚠️ `cargo-near` breaking changes ``` --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/constructible_struct_adds_field.ron Failed in: field InteractiveClapContextScopeForBuildCommand.no_wasmopt in /tmp/.tmp9RlqrE/cargo-near/cargo-near/src/commands/build_command/mod.rs:5 field InteractiveClapContextScopeForBuildCommand.env in /tmp/.tmp9RlqrE/cargo-near/cargo-near/src/commands/build_command/mod.rs:5 field CliBuildCommand.no_wasmopt in /tmp/.tmp9RlqrE/cargo-near/cargo-near/src/commands/build_command/mod.rs:5 field CliBuildCommand.env in /tmp/.tmp9RlqrE/cargo-near/cargo-near/src/commands/build_command/mod.rs:5 ``` ###⚠️ `cargo-near-build` breaking changes ``` --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/constructible_struct_adds_field.ron Failed in: field Opts.no_wasmopt in /tmp/.tmp9RlqrE/cargo-near/cargo-near-build/src/types/near/build/input/mod.rs:34 field Opts.env in /tmp/.tmp9RlqrE/cargo-near/cargo-near-build/src/types/near/build/input/mod.rs:51 --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/method_parameter_count_changed.ron Failed in: cargo_near_build::BuildOpts::get_cli_build_command_in_docker now takes 3 parameters instead of 2, in /tmp/.tmp9RlqrE/cargo-near/cargo-near-build/src/types/near/build/input/docker_context.rs:19 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `cargo-near` <blockquote> ## [0.10.0](cargo-near-v0.9.0...cargo-near-v0.10.0) - 2024-10-16 ### Added - [**breaking**] use `wasm-opt -O` (via wasm-opt-rs) as post-step of build ([#231](#231)) - `env` flag for external parameters of docker build and regular build ([#226](#226)) ### Other - Use Posthog instead of Mixpanel to collect stats on new projects creation ([#227](#227)) - Fix tracking usage ([#225](#225)) </blockquote> ## `cargo-near-build` <blockquote> ## [0.2.0](cargo-near-build-v0.1.1...cargo-near-build-v0.2.0) - 2024-10-16 ### Added - [**breaking**] use `wasm-opt -O` (via wasm-opt-rs) as post-step of build ([#231](#231)) - `env` flag for external parameters of docker build and regular build ([#226](#226)) ### Other - disable github release for `cargo-near-build` via cargo-dist ([#222](#222)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
We have to change the PostHog API key before merging