Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docker image and sdk version in cargo near new template #218

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Sep 5, 2024

1 cargo-near/src/commands/new/new-project-template/Cargo.toml.template:

  • near-sdk version to 5.4
  • modify image to latest at moment of changing
  • near-workspaces version to 0.13
  1. integration-tests/Cargo.toml
  • near-workspaces version to 0.13
  1. integration-tests/src/lib.rs
  • from_git::SDK_REVISION to 5.4 pointer

@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Sep 5, 2024

@race-of-sloths ping

@race-of-sloths
Copy link

race-of-sloths commented Sep 5, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Are you going to win race-of-sloths this month? If so, you should speed up! Run, Sloth, run!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 3

Your contribution is much appreciated with a final score of 3!
You have received 74 (30 base + 40 weekly bonus + 5% lifetime bonus) Sloth points for this contribution

Another weekly streak completed, well done @dj8yfo! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Sep 5, 2024

@akorchyn
does the template has to wait for near-workspaces = { version = "0.12.0", features = ["unstable"] }
version bump 0.12.0 -> 0.13.0?

it looks like it should

@dj8yfo dj8yfo marked this pull request as ready for review September 5, 2024 11:07
@akorchyn
Copy link
Contributor

akorchyn commented Sep 5, 2024

near-sdk works with the old version as well. (As It has circular dependency with workspace as well)
So, I don't think it's a blocker. Though, we might wait to reduce amount of releases

Upd:
But it will pull a lot of extra deps, so it's better to wait I guess

@frol
Copy link
Contributor

frol commented Sep 5, 2024

Yeah, and also near-workspace-rs would greatly benefit from migrating from cargo-near dependency to cargo-near-build

@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Sep 5, 2024

done (?) near/near-workspaces-rs#373

@dj8yfo dj8yfo marked this pull request as draft September 5, 2024 17:42
@dj8yfo dj8yfo marked this pull request as ready for review September 10, 2024 14:30
@akorchyn
Copy link
Contributor

I think we can update it now.

@akorchyn
Copy link
Contributor

Actually, 0.26 is released :( Let's maybe use it as well. I'll try to push release as fast as I can :)

Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 3

@frol frol merged commit b1bc1ff into near:main Sep 11, 2024
17 checks passed
@frol frol mentioned this pull request Sep 11, 2024
frol added a commit that referenced this pull request Sep 13, 2024
## 🤖 New release
* `cargo-near`: 0.8.2 -> 0.9.0
* `cargo-near-build`: 0.1.0 -> 0.1.1

<details><summary><i><b>Changelog</b></i></summary><p>

## `cargo-near`
<blockquote>

##
[0.9.0](cargo-near-v0.8.2...cargo-near-v0.9.0)
- 2024-09-12

### Added

- Fixed GitHub CI staging workflow generated by `cargo near new` command
to work correctly with docker case
([#193](#193))
- Extracted cargo-near-build into a standalone crate to be able to use
it in near-workspaces and other places without the rest of the heavy
dependencies of cargo-near
([#198](#198))
- Added tracking of `cargo near new` usage to collect statistics of the
command usage ([#192](#192))

### Fixed

- Addressed warnings in `cargo build -p cargo-near-build` cmd in
releaze-plz flow ([#212](#212))

### Other

- Updated near-* dependencies to 0.26 release
([#220](#220))
- Use "tracing" for logging and loading indicators
([#216](#216))
- update docker image and sdk version in `cargo near new` template
([#218](#218))
- [**breaking**] updates near-* packages to 0.25 version. Updates
near-sdk to 5.4 ([#215](#215))
</blockquote>

## `cargo-near-build`
<blockquote>

##
[0.1.1](cargo-near-build-v0.1.0...cargo-near-build-v0.1.1)
- 2024-09-12

### Added

- Fixed GitHub CI staging workflow generated by `cargo near new` command
to work correctly with docker case
([#193](#193))

### Other

- Use "tracing" for logging and loading indicators
([#216](#216))
- fix clippy ([#219](#219))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants