Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New command - create-dev-account #108

Merged
merged 2 commits into from
Oct 19, 2023
Merged

feat: New command - create-dev-account #108

merged 2 commits into from
Oct 19, 2023

Conversation

FroVolod
Copy link
Collaborator

@FroVolod FroVolod commented Oct 8, 2023 •
edited
Loading

Resolves #106

frol
frol requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. I suggest removing tests for create-dev-account for now and getting back to the testing infrastructure later.

cargo-near/src/commands/create_dev_account/mod.rs Outdated Show resolved Hide resolved
@FroVolod FroVolod marked this pull request as ready for review October 9, 2023 11:41
@FroVolod FroVolod changed the title feat: New command - create-dev-account feat: New commands - create-dev-account, deploy Oct 9, 2023
@FroVolod FroVolod marked this pull request as draft October 9, 2023 14:25
@FroVolod FroVolod changed the title feat: New commands - create-dev-account, deploy feat: New commands - create-dev-account Oct 9, 2023
@FroVolod FroVolod marked this pull request as ready for review October 9, 2023 16:57
@FroVolod FroVolod changed the title feat: New commands - create-dev-account feat: New command - create-dev-account Oct 13, 2023
frol
frol requested changes Oct 19, 2023
View reviewed changes
cargo-near/src/commands/abi_command/mod.rs Outdated Show resolved Hide resolved
cargo-near/src/commands/build_command/mod.rs Outdated Show resolved Hide resolved
@frol frol enabled auto-merge (rebase) October 19, 2023 10:55
@frol frol merged commit a4cecb6 into main Oct 19, 2023
14 checks passed
@frol frol deleted the create-dev-account branch October 19, 2023 11:04
frol pushed a commit that referenced this pull request Oct 19, 2023
@frol
feat: New command - create-dev-account (#108)
577c41b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo near create-dev-account command to ease development on testnet
2 participants
@FroVolod @frol