-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C1 home page #309
base: master
Are you sure you want to change the base?
C1 home page #309
Conversation
@MennaAshraf in the UMLs in the condition box you should write else also, the condition in the brackets is not written correctly . Another thing is that you are writing what the controller method is doing so please check that |
@MennaAshraf please tell me which tests have you added because there are many tests that appear to me that you have changed them but they aren't related to your task also please hook the issue because i cant find it |
@Hoss93 which uml ? i mean which story |
@MennaAshraf all the UMLs |
@Hoss93 fixed it, please check. |
@MennaAshraf you haven't covered all the cases so please get the gem that Omar told us about to test coverage in your tests |
@@ -0,0 +1,6 @@ | |||
class ChoiceQquestion < ActiveRecord::Base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model has no documentation
documentation reopened. Please refer to the comments |
@mayaammar i did the documentation for the project controller (index , new , create , destroy ) and for the model project.rb. |
okay @MennaAshraf then document def get_thumbnail in the project model. |
@mayaammar done, please check. |
doc verified @MennaAshraf |
Pull request moved to #317 |
@Malatawy15 @Hoss93 @georgesamy @mayaammar please review my branch.
#83 #84 #127