Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C1 home page #309

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

C1 home page #309

wants to merge 44 commits into from

Conversation

MennaAshraf
Copy link
Collaborator

@Malatawy15 @Hoss93 @georgesamy @mayaammar please review my branch.
#83 #84 #127

@hossam-mossalam
Copy link
Collaborator

@MennaAshraf in the UMLs in the condition box you should write else also, the condition in the brackets is not written correctly . Another thing is that you are writing what the controller method is doing so please check that

@hossam-mossalam
Copy link
Collaborator

@MennaAshraf please tell me which tests have you added because there are many tests that appear to me that you have changed them but they aren't related to your task also please hook the issue because i cant find it

@MennaAshraf
Copy link
Collaborator Author

@Hoss93 which uml ? i mean which story
and for the tests i changed in projects_controller_spec.rb (controller) and project_spec (model)

@hossam-mossalam
Copy link
Collaborator

@MennaAshraf all the UMLs

@MennaAshraf
Copy link
Collaborator Author

@Hoss93 fixed it, please check.

@hossam-mossalam
Copy link
Collaborator

@MennaAshraf you haven't covered all the cases so please get the gem that Omar told us about to test coverage in your tests

@@ -0,0 +1,6 @@
class ChoiceQquestion < ActiveRecord::Base
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model has no documentation

@mayaammar
Copy link
Collaborator

documentation reopened. Please refer to the comments

@mayaammar mayaammar closed this May 1, 2013
@mayaammar mayaammar reopened this May 1, 2013
@MennaAshraf
Copy link
Collaborator Author

@mayaammar i did the documentation for the project controller (index , new , create , destroy ) and for the model project.rb.

@mayaammar
Copy link
Collaborator

okay @MennaAshraf then document def get_thumbnail in the project model.

@MennaAshraf
Copy link
Collaborator Author

@mayaammar done, please check.

@mayaammar
Copy link
Collaborator

doc verified @MennaAshraf

@MennaAshraf
Copy link
Collaborator Author

Pull request moved to #317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants