Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C2 s12 save report #227

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

C2 s12 save report #227

wants to merge 33 commits into from

Conversation

HeshamW
Copy link
Collaborator

@HeshamW HeshamW commented Apr 10, 2013

maged918
maged918 reviewed Apr 12, 2013
View reviewed changes
Rails/WebsitesPrototypeBuilder/app/controllers/projects_controller.rb
@@ -0,0 +1,4 @@
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again is this needed?

@ahmed-osama-saad
Copy link
Collaborator

test reviewed

@SarahNouh
Copy link
Collaborator

fix conflicts

@HeshamW
Copy link
Collaborator Author

HeshamW commented Apr 12, 2013

@maged918 @ahmed-osama-saad @Hoss93 Please check again

maged918
maged918 reviewed Apr 12, 2013
View reviewed changes
Rails/WebsitesPrototypeBuilder/app/views/tasks/show.html.erb
</tr>
<% @task.task_results.each do |result| %>
<%if result.reviewer %>
<tr>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent code inside if

@maged918
Copy link
Collaborator

recheck comments

@SarahNouh
Copy link
Collaborator

fix conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HeshamW @ahmed-osama-saad @SarahNouh @maged918