-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newsletters feature implemented. #232
base: master
Are you sure you want to change the base?
Conversation
To cover the build failures, #231 must be merged first. |
@dhruvhacks Please add the newsletter models along with the migration files in a separate PR. |
- Views to access Newsletters of various departments. - Access to specific groups to add new Newsletters.
@RishabhJain2018 Okay sir. |
@RishabhJain2018 Please review #233. It contains the models and migration files of this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhruvhacks Please add the screenshots of the UI.
@RishabhJain2018
|
@RishabhJain2018 Sir please do not merge this PR before merging #233 into this branch. This way complete feature can be tested once. Target of #233 is already set to this branch. |
@dhruvhacks Feel free to merge this as well as per your plan. |
@RishabhJain2018 Okay sir! Since this PR is stale, will update it and consider merging! |
This PR adds-
closes #229
@RishabhJain2018 please review 🙂