Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters feature implemented. #232

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Newsletters feature implemented. #232

wants to merge 2 commits into from

Conversation

dhruvhacks
Copy link
Member

@dhruvhacks dhruvhacks commented May 15, 2018

This PR adds-

  • Views to access Newsletters of various departments.
  • Access to specific groups to add new Newsletters.
  • Templates for newsletters section.

closes #229

@RishabhJain2018 please review 🙂

@dhruvhacks
Copy link
Member Author

To cover the build failures, #231 must be merged first.

@RishabhJain2018
Copy link
Member

RishabhJain2018 commented May 26, 2018

@dhruvhacks Please add the newsletter models along with the migration files in a separate PR.

- Views to access Newsletters of various departments.
- Access to specific groups to add new Newsletters.
@dhruvhacks
Copy link
Member Author

@RishabhJain2018 Okay sir.

@dhruvhacks
Copy link
Member Author

dhruvhacks commented May 29, 2018

@RishabhJain2018 Please review #233. It contains the models and migration files of this feature.

Copy link
Member

@RishabhJain2018 RishabhJain2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruvhacks Please add the screenshots of the UI.

@dhruvhacks
Copy link
Member Author

dhruvhacks commented Jul 8, 2018

@RishabhJain2018
Sure sir! Here are the screenshots of the UI-

  1. Newsletters link will be available left menu.
    image

  2. This link will redirect to a page which lists all the departments. This will be a open link. But for a logged in user, if they are among the authorized groups, they will get a 'Add new' button-
    image

  3. Selecting a menu will list all the newsletters uploaded by that department. If no newsletter found, page will display 'No newsletter Found'
    image
    image

  4. For an authorized member, a form will be provided for uploading newsletters-
    image

@dhruvhacks
Copy link
Member Author

@RishabhJain2018 Sir please do not merge this PR before merging #233 into this branch. This way complete feature can be tested once. Target of #233 is already set to this branch.

@RishabhJain2018
Copy link
Member

@dhruvhacks Feel free to merge this as well as per your plan.

@dhruvhacks
Copy link
Member Author

@RishabhJain2018 Okay sir! Since this PR is stale, will update it and consider merging!

@dhruvhacks dhruvhacks added the stale Needs re-work label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Needs re-work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Newsletters' feature in Infoconnect.
2 participants