Skip to content

Commit

Permalink
don't build the tests for acquire test dependencies (acquire-project#83)
Browse files Browse the repository at this point in the history
This resolves a failure to build tests that we're currently experiencing
on main.

Tests pull in acquire libraries (like `acquire-driver-common` and
`acquire-video-runtime`) as dependencies. These are brought in as
submodules and compiled with the tests.

Doing things this way, also causes the tests in the dependencies. That
can be nice because we make sure the dependencies are running correctly,
but it introduces all kinds of build shenanigans and is somewhat
wasteful. We tend to have good observability on whether the dependencies
are working anyway.

So this PR uses the `NOTEST` variable in the `test/CMakeLists.txt` to
turn off the building of tests in dependencies.
  • Loading branch information
nclack committed Aug 14, 2023
1 parent d00eaf5 commit c8ec599
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
if(${NOTEST})
message(STATUS "Skipping test targets")
else()
set(NOTEST "TRUE")
aq_require(acquire-video-runtime)
aq_require(acquire-driver-common)
set(NOTEST "FALSE")

#
# PARAMETERS
Expand Down

0 comments on commit c8ec599

Please sign in to comment.