Sped up testing and AA kmer counting (with Rcpp) #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it in helper-testing_functions.R, added v2 to Rcmd check workflow
|
The latest push changed a bunch of the vdiffr svgs. I found that - at least on my local device - many of the vdiffr plots are failing because the legend on the right side was flipped and nothing wrong with the main graphic. Im not sure why its different on my device, it may be because Im on some wrong version of one of the plotting libraries? But either way, locally, 2 tests are still failing. One of which is the STARTRAC output which has some floating point differences in some string versions of numbers? And the other one is clonalBias where the dotted line is missing. |
ncborcherding
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit msgs for details. main thing is that testing is much much faster now since
combinedhas been saved as a test object. AA kmer counting also works now in Rcpp and is faster for 1 < k <= 12. Although AA counting with k any larger than 6 takes forever to run which makes sense as the number of bins scale exponentially