-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts,GitHubCI,Backend: add .NET6 snap #207
scripts,GitHubCI,Backend: add .NET6 snap #207
Conversation
Fix error? What error? Please dump the whole error in the commit message, no need to be secretive about it.
This needs to be fixed indeed, otherwise the snap package is unnecessarily big.
No. As I suggested in the review, first change make.fsx to call dotnet publish (the developer should not need to know the way to call dotnet publish, the point of using Makefiles is to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When addressing my last review, while you're at it, please squash into 1 commit, there's no reason to separate this into different commits, unless I'm missing something. |
@webwarrior-ws 2 things:
|
A 3rd thing actually: given that we're maintaining the mono snap package instead of changing it to always use dotnet, the title of commit msg (and PR title) needs to be updated. |
Last thing to fix before I merge this is cosmetic:
|
Use .NET6 to build snap package. Publish Frontend.Console as single executable in in snap_build script. Modified launch script to point to gwallet executable generated with new settings. Set InvariantGlobalization to true in Backend and Frontend.Console projects to fix error when launching gwallet installed by snap. Error in question was: Process terminated. Couldn't find a valid ICU package installed on the system. Please install libicu using your package manager and try again. Alternatively you can set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support. Set correct configPath when GWallet is in a snap package. Build mono snap package alongside .net6. Also upload mono snap package as artifact and test it. It is needed because the frontend branch can't switch yet to dotnet-based snap. When building snap package with .NET6, only include single-file executable in package. Added "publish" command to make.fsx and Makefile.
Updated commit message and PR title/description |
1a3be72
to
265b103
Compare
b841302
to
ccb1641
Compare
Superseded by #297 |
Use .NET6 to build snap package.
Publish Frontend.Console as single executable in in snap_build
script.
Modified launch script to point to gwallet executable generated
with new settings.
Set InvariantGlobalization to true in Backend and
Frontend.Console projects to fix error when launching
gwallet installed by snap.
Error in question was:
Process terminated. Couldn't find a valid ICU package installed
on the system. Please install libicu using your package manager
and try again. Alternatively you can set the configuration flag
System.Globalization.Invariant to true if you want to run with
no globalization support.
Set correct configPath when GWallet is in a snap package.
Build mono snap package alongside .net6. Also upload mono snap
package as artifact and test it.
It is needed because the frontend branch can't switch yet to
dotnet-based snap.
When building snap package with .NET6, only include single-file
executable in package.
Added "publish" command to make.fsx and Makefile.
Superseded by #297