Skip to content

Commit

Permalink
ReadMe,Directory.Build.props: minor adjustments
Browse files Browse the repository at this point in the history
  • Loading branch information
knocte committed Aug 18, 2023
1 parent 2cc3227 commit 190356d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
<Project>
<!-- TODO: check if we can use WarnOn instead of OtherFlags below:
(see https://github.com/dotnet/fsharp/pull/10885 ) -->
<PropertyGroup>
<OtherFlags>$(OtherFlags) --warnon:0193</OtherFlags>
<OtherFlags>$(OtherFlags) --warnon:1182</OtherFlags>
<OtherFlags>$(OtherFlags) --warnon:3218</OtherFlags>

<!-- not sure if this one below was already ON by default,
but it is so important that we add it just in case: -->
<OtherFlags>$(OtherFlags) --warnon:0020</OtherFlags>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)' != 'Debug' ">
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
Expand Down
2 changes: 1 addition & 1 deletion ReadMe.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Unfinished tasks so far:
* Revamp this ReadMe.md file to remove any mentions to Mono or the legacy .NET4.x framework.
* Remove legacy framework support (so that build system can converge into .fsx files instead of autotools in Unix + fsx in Windows).
* Make fsxc always enable warnAsError and fsx always disable it.
* After doing the above, make both fsx and fsxc always enable warnAsError for the warning described in https://stackoverflow.com/questions/38202685/fsx-script-ignoring-a-function-call-when-i-add-a-parameter-to-it
* After doing the above, make both fsx and fsxc always enable warnAsError for the FS0020 warning described in https://stackoverflow.com/questions/38202685/fsx-script-ignoring-a-function-call-when-i-add-a-parameter-to-it
* Try creating VMs for CI that uninstall .NETCore/.NET6 completely (not just the dotnet executable removal hack), to make sure legacy framework build still works there.
* Try creating VMs for CI that uninstall Mono/.NET4.x completey (e.g. for macOS see: https://github.com/mono/website/commit/490797429d4b92584394292ff69fbdc0eb002948 )

Expand Down

0 comments on commit 190356d

Please sign in to comment.