Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Angular 16 #169

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Migrate to Angular 16 #169

merged 4 commits into from
Jul 14, 2023

Conversation

ArtemDintecom
Copy link
Contributor

Improved:

  • Make a standalone directive and drop of the module
  • Renamed CurrencyMaskConfig to NgxCurrencyConfig
  • Renamed CurrencyMaskInputMode to NgxCurrencyInputMode
  • Renamed CURRENCY_MASK_CONFIG to NGX_CURRENCY_CONFIG
  • Renamed CurrencyMaskDirective to NgxCurrencyDirective
  • Now you can partially override the global configuration
  • Stronger project typing, drop of any
  • Changed project structure to build via Angular CLI
  • Updated README to use provideEnvironmentNgxCurrency instead of forRoot

Broke/lost:

  • Travis-CI
  • standard-version (it is outdated and I still don't know what to migrate it to)
  • scripts for publishing a new version
  • May be something else...

Closes #152, #153, #155, #167

BREAKING CHANGE: migration to standalone components
BREAKING CHANGE: more predictable directive and config names
feat: partial global config override allowed
refactor: stronger typing
refactor: using the standard Angular project structure
@ThemisCol
Copy link

ThemisCol commented Mar 14, 2023

Excellent contribution.

The test (should return null because the nullable parameterization is true) have error.

Argument of type 'number' is not assignable to parameter of type 'Expected<ArrayLike> | ArrayContaining'.ts(2345)

@ArtemDintecom
Copy link
Contributor Author

@ThemisCol I swapped expected and actual values. But I did not understand where there is a mismatch of types? Could you describe in a little more detail?

@pumano
Copy link

pumano commented Apr 6, 2023

any news on this? Library become totally not working since 16 angular

@ArtemDintecom
Copy link
Contributor Author

ArtemDintecom commented Apr 6, 2023

@pumano Looks like we'll have to wait a long time for the owner of the library. But I don’t really want to upload my project to npm and change the package name throughout the code. So I just added this to package.json:

  "dependencies": {
    ...
    "ngx-currency": "https://github.com/dintecom/ngx-currency-dist#v16.0.0-1",
    ...
  }

You can do the same or build the package yourself, fortunately now it's easy to do, with one command npm run build:lib

@ArtemDintecom ArtemDintecom changed the title Migrate to Angular 15 Migrate to Angular 16 May 6, 2023
@steflen-kxl
Copy link

Would love to see this soon

@gamoreli
Copy link

gamoreli commented Jul 8, 2023

Hey guys, could you please merge it?

@selangley-wa
Copy link

Merge this?
@nbfontana

@nbfontana
Copy link
Owner

nbfontana commented Jul 14, 2023

Hey devs,

First of all, thank you @ArtemDintecom!

I'm really late to this one and it is a deal breaker for lots of projects for sure.

I'm not as close to Angular as I used to be and might not be the best person to review, refactor or search for possible nuances within all of the changes in this PR. Although I'll work on releasing this as a new major version today, do some smoke testing.

The GitHub Notifications are a bit overwhelming and when mixed with work stuff it gets hard to even circle back to a PR that a saved on my todo list months ago 🫠

I could easily add a bunch of you that are using the lib as collaborators, secure master, and request a minimal number of CR approvals so it's more spread and I don't leave it blocked... Will then work on improving the release so it's also no a blocker while keeping it secure and solid.

Thoughts?

@nbfontana nbfontana merged commit 4b52777 into nbfontana:master Jul 14, 2023
@ArtemDintecom ArtemDintecom deleted the upgrade branch July 17, 2023 12:10
@ArtemDintecom
Copy link
Contributor Author

@nbfontana Thank you for releasing a new version!
You want one of us to additionally review future pull requests, and you will pay more attention to releases of new versions, right? You can add me to the collaborators, but I think this is not necessary. I can simply subscribe to any pull requests changes in this repository and review them when I have free time.

@nbfontana
Copy link
Owner

@ArtemDintecom sounds good to me!

I'll try to update my notification warnings to get e-mails from this repo. Since I don't get e-mails from anything else on Github that should work as a good reminder 😅

Also need to revisit a few things since some dev things stopped working on 4.0.0, like auto-generating versions/changelogs etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants