-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Angular 16 #169
Conversation
BREAKING CHANGE: migration to standalone components BREAKING CHANGE: more predictable directive and config names feat: partial global config override allowed refactor: stronger typing refactor: using the standard Angular project structure
Excellent contribution. The test (should return null because the nullable parameterization is true) have error. Argument of type 'number' is not assignable to parameter of type 'Expected<ArrayLike> | ArrayContaining'.ts(2345) |
@ThemisCol I swapped expected and actual values. But I did not understand where there is a mismatch of types? Could you describe in a little more detail? |
any news on this? Library become totally not working since 16 angular |
@pumano Looks like we'll have to wait a long time for the owner of the library. But I don’t really want to upload my project to npm and change the package name throughout the code. So I just added this to package.json: "dependencies": {
...
"ngx-currency": "https://github.com/dintecom/ngx-currency-dist#v16.0.0-1",
...
} You can do the same or build the package yourself, fortunately now it's easy to do, with one command |
Would love to see this soon |
Hey guys, could you please merge it? |
Merge this? |
Hey devs, First of all, thank you @ArtemDintecom! I'm really late to this one and it is a deal breaker for lots of projects for sure. I'm not as close to Angular as I used to be and might not be the best person to review, refactor or search for possible nuances within all of the changes in this PR. Although I'll work on releasing this as a new major version today, do some smoke testing. The GitHub Notifications are a bit overwhelming and when mixed with work stuff it gets hard to even circle back to a PR that a saved on my todo list months ago 🫠 I could easily add a bunch of you that are using the lib as collaborators, secure master, and request a minimal number of CR approvals so it's more spread and I don't leave it blocked... Will then work on improving the release so it's also no a blocker while keeping it secure and solid. Thoughts? |
@nbfontana Thank you for releasing a new version! |
@ArtemDintecom sounds good to me! I'll try to update my notification warnings to get e-mails from this repo. Since I don't get e-mails from anything else on Github that should work as a good reminder 😅 Also need to revisit a few things since some dev things stopped working on 4.0.0, like auto-generating versions/changelogs etc |
Improved:
CurrencyMaskConfig
toNgxCurrencyConfig
CurrencyMaskInputMode
toNgxCurrencyInputMode
CURRENCY_MASK_CONFIG
toNGX_CURRENCY_CONFIG
CurrencyMaskDirective
toNgxCurrencyDirective
any
provideEnvironmentNgxCurrency
instead offorRoot
Broke/lost:
Closes #152, #153, #155, #167