fix: Blob might be undefined

nbesli · Jan 27, 2024 · 4d6816c · 4d6816c
1 parent 42b0302
commit 4d6816c
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 113 deletions.
diff --git a/PDFMergerBase.js b/PDFMergerBase.js
@@ -155,7 +155,7 @@ export default class PDFMergerBase {
     }
 
     // see https://developer.mozilla.org/en-US/docs/Web/API/Blob
-    if (input instanceof Blob) {
+    if (Blob && input instanceof Blob) {
       const aBuffer = await input.arrayBuffer()
       return new Uint8Array(aBuffer)
     }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -32,7 +32,6 @@
     "pdf-lib": "^1.17.1"
   },
   "devDependencies": {
-    "cross-blob": "^3.0.2",
     "fs-extra": "^11.2.0",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",

diff --git a/test/PDFMerger.test.js b/test/PDFMerger.test.js
@@ -1,7 +1,6 @@
 import path from 'path'
 
 import fs from 'fs-extra'
-import Blob from 'cross-blob'
 import pdfDiff from 'pdf-diff'
 import { PDFDocument } from 'pdf-lib'
 import { jest } from '@jest/globals'
@@ -103,7 +102,7 @@ describe('PDFMerger', () => {
       expect(diff).toBeFalsy()
     })
 
-    test('provide input as Blob', async () => {
+    (Blob ? test : test.skip)('provide input as Blob', async () => {
       const merger = new PDFMerger()
       const TestfileAUint8Array = await fs.readFile(path.join(FIXTURES_DIR, 'Testfile_A.pdf'))
       const TestfileABlob = new Blob([TestfileAUint8Array])