Ignore no-op load/save/delete actions properly

[nbali]

• the goal is to avoid the small, but potentially frequently executed calls to save CPU

---

This change is 

[nbali]

@fpeter8 pls, thx

[fpeter8]

Collections.emptyMap();? Or you want it to be writable?

[nbali]

TBH there is no proper consistency in the objectify itself, for example
some uses empty map, some new hashmap, but this method returned this
originally, so seemed like a good idea to keep it.
2015.10.19. 13:18 ezt írta ("Peter Farkas" [email protected]):

In src/main/java/com/googlecode/objectify/impl/LoadTypeImpl.java
#1 (comment):

@@ -122,6 +123,10 @@
for (S id: ids)
keymap.put(this.makeKey(id), id);

•   if (keymap.isEmpty()) {
  

•       return Maps.newLinkedHashMap();
  

Collections.emptyMap();? Or you want it to be writable?

—
Reply to this email directly or view it on GitHub
https://github.com/nbali/objectify/pull/1/files#r42359680.

[fpeter8]

please follow code conventions (one-line ifs don't have brackets)

[nbali]

Funny part again, sometimes they dont, sometimes they do ;-)
2015.10.19. 13:20 ezt írta ("Peter Farkas" [email protected]):

please follow code conventions (one-line ifs don't have brackets)

—
Reply to this email directly or view it on GitHub
#1 (comment).

[fpeter8]

why did you modify LoadTypeImpl? It calls LoaderImpl (which contains the empty clause already). If this is such an improvement, why not SaveTypeImpl and DeleteTypeImpl?

[nbali]

I wanted to avoid the unnecessary proxying, but you are right test should
include proxy creation as well
2015.10.19. 13:24 ezt írta ("Peter Farkas" [email protected]):

why did you modify LoadTypeImpl? It calls LoaderImpl (which contains the
empty clause already). If this is such an improvement, why not SaveTypeImpl
and DeleteTypeImpl?

—
Reply to this email directly or view it on GitHub
#1 (comment).

[nbali]

@fpeter8 next round pls

[fpeter8]

I'll need to check the Round implementation to be sure now - nowUncached change is fine, the rest seems OK

[fpeter8]

@nbali FYI I've updated the master branch