Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing depreceated HttpKernel\DependencyInjection\Extension class which is now considered internal #75

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fixing depreceated HttpKernel\DependencyInjection\Extension class which is now considered internal #75

merged 1 commit into from
Sep 10, 2024

Conversation

lucasfoussier
Copy link
Contributor

@lucasfoussier lucasfoussier commented Sep 8, 2024

With the latest Symfony versions(7.1) , we have some depreceated reported in logs :

The "Symfony\Component\HttpKernel\DependencyInjection\Extension" class is considered internal since Symfony 7.1, to be deprecated in 8.1; use Symfony\Component\DependencyInjection\Extension\Extension instead. It may change without further notice. You should not use it from "Nzo\UrlEncryptorBundle\DependencyInjection\NzoEncryptorExtension".

To fix this, change the import in the file Nzo\UrlEncryptorBundle\DependencyInjection\NzoEncryptorExtension as suggested fix the issues.

As described in the composer.json the bundle support the version starting with symfony version > 4.4 (^4.4|^5.0|^6.0|^7.0).
The suggested class used in this PR was already available in 4.4 as you can see here : https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/DependencyInjection/Extension/Extension.php so it should be harmless for all the users of the bundle.

@lucasfoussier lucasfoussier changed the title Fixing depreceated HttpKernel\DependencyInjection\Extension class whi… Fixing depreceated HttpKernel\DependencyInjection\Extension class which is now considered internal Sep 8, 2024
@nayzo
Copy link
Owner

nayzo commented Sep 10, 2024

Thanks @lucasfoussier

@nayzo nayzo merged commit 3a8299a into nayzo:master Sep 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants