Add init_params/1 callback for item actions
#673
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flo0807
changed the title
init_params/1 callback to item actionsinit_params/1 callback for item actions
Flo0807
commented
Nov 27, 2024
|
|
||
| changeset_function = &action.module.changeset/3 | ||
|
|
||
| metadata = Resource.build_changeset_metadata(socket.assigns) | ||
|
|
||
| changeset = changeset_function.(base_item, %{}, metadata) | ||
| changeset = changeset_function.(base_item, init_params, metadata) |
There was a problem hiding this comment.
@pehbehbeh We should combine this with the default values users can define for fields. Currently, we do not use these values in Item Actions (we do in Resource Actions: see https://github.com/naymspace/backpex/blob/develop/lib/backpex/live_resource.ex#L794)
What are your thoughts on using the init_params if defined and otherwise the default values (same for resource actions)?
Something like this:
init_params = action.module.init_params(socket.assigns) || build_default_paramsIf both init_params and "default" field values are not present an empty map is being used.
Base automatically changed from
feature/rename-item-action-init-change-callback
to
develop
November 27, 2024 10:21
pehbehbeh
approved these changes
Nov 27, 2024
|
|
||
| changeset_function = &action.module.changeset/3 | ||
|
|
||
| metadata = Resource.build_changeset_metadata(socket.assigns) | ||
|
|
||
| changeset = changeset_function.(base_item, %{}, metadata) | ||
| changeset = changeset_function.(base_item, init_params, metadata) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.