Gemforge dev merged #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarinkovic
force-pushed
the
gemforge-dev-merged
branch
3 times, most recently
from
e94db47
to
f779105
Compare
amarinkovic
force-pushed
the
gemforge-dev-merged
branch
from
f779105
to
3f3b0ca
Compare
|
Looks like tests need slight fixing. |
amarinkovic
force-pushed
the
gemforge-dev-merged
branch
2 times, most recently
from
f3276a5
to
24569f2
Compare
amarinkovic
force-pushed
the
gemforge-dev-merged
branch
from
24569f2
to
1040dba
Compare
amarinkovic
added a commit
that referenced
this pull request
Nov 13, 2023
* feat: introduce gemforge * fix: compilation issues * fix: more compilation errors * contracts are now compiling * fix some issues * Update submodule deps * oh yeah oh yeah * add deployment command * ensure sys admin is != owner * chore: got upgrade working for local nodes * docs: add instructions for anvil * deploy using nayms standard addresses and mnemonic * feat: etherscan verification * upgrade gemforge to 2.5.0 * fix: owner account index * chore: do not append metadata bytecode hash to runtime bytecode * test: test deployment working * test fixes * more test fixes * all tests working! * Gemforge dev merged (#91) * merge dev branch * CI: fix test wallet * chore: downgrade to solc 0.8.20 * feat: add base goerli network * fix: object id check for address type * fix: start versioning deployments file * refactor: gemforge script now split into modules * feat: mainnet upgrade script + readme * rm old path for oz lib * fix: test failing due to base goerli rpc not set * refactor: secret name * new sepolia upgrade! * build: sepolia upgraded! * build: remove temp facet, back to standard * add mainnet address to new deployments json * chore: have coverage ignore generated and init folders in src * simplify deploy scripts into one * chore: add config for mainnet fork * update gemforge * test: bring back fork tests [wip] * chore: remove diamond-2-hardhat * forge install: diamond-2-hardhat gemforge-2 * chore: lock diamond-2-hardhat submodule to gemforge-2 branch * chore: remove smart deploy scripts * chore: rm old scripts * chore: comment out some old solidity scripts * chore: rm old scripts * chore: rm old interfaces * chore: remove some more obsolete scripts --------- Co-authored-by: Ramesh Nair <[email protected]> Co-authored-by: Kevin Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
devbranch intogemforge.