Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nav 160 create gtfs subset writer app #33

Merged
merged 14 commits into from
Aug 30, 2024

Conversation

Brunner246
Copy link
Contributor

No description provided.

@Brunner246 Brunner246 requested review from clukas1 and munterfi August 26, 2024 05:53
munterfi
munterfi previously approved these changes Aug 27, 2024
@munterfi
Copy link
Member

Wait 😄 Somehow the build fails on unix:

[ 90%] Linking CXX executable /home/runner/work/raptorxx/raptorxx/output/bin/release/raptor_tests
[ 90%] Built target raptor_tests
[ 91%] Building CXX object src/gtfsRaptorConfig/CMakeFiles/gtfsRaptorConfig.dir/src/GtfsToRaptorConverter.cpp.o
[ 93%] Building CXX object src/gtfsRaptorConfig/CMakeFiles/gtfsRaptorConfig.dir/src/RoutePartitioner.cpp.o
/home/runner/work/raptorxx/raptorxx/src/gtfsRaptorConfig/src/RoutePartitioner.cpp: In member function ‘std::vector<converter::SubRoute> converter::RoutePartitioner::getSubRoutes(const std::string&) const’:
/home/runner/work/raptorxx/raptorxx/src/gtfsRaptorConfig/src/RoutePartitioner.cpp:31:73: error: ‘to’ is not a member of ‘std::ranges’
   31 |     return std::ranges::views::values(subRoutesForRoute) | std::ranges::to<std::vector<SubRoute>>();
      |                                                                         ^~
/home/runner/work/raptorxx/raptorxx/src/gtfsRaptorConfig/src/RoutePartitioner.cpp:31:96: error: expected primary-expression before ‘>’ token
   31 |     return std::ranges::views::values(subRoutesForRoute) | std::ranges::to<std::vector<SubRoute>>();
      |                                                                                                ^~
/home/runner/work/raptorxx/raptorxx/src/gtfsRaptorConfig/src/RoutePartitioner.cpp:31:99: error: expected primary-expression before ‘)’ token
   31 |     return std::ranges::views::values(subRoutesForRoute) | std::ranges::to<std::vector<SubRoute>>();
      |                                                                                                   ^
gmake[2]: *** [src/gtfsRaptorConfig/CMakeFiles/gtfsRaptorConfig.dir/build.make:90: src/gtfsRaptorConfig/CMakeFiles/gtfsRaptorConfig.dir/src/RoutePartitioner.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:1395: src/gtfsRaptorConfig/CMakeFiles/gtfsRaptorConfig.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
Error: Process completed with exit code 2.

@munterfi munterfi self-requested a review August 27, 2024 11:52
@munterfi munterfi dismissed their stale review August 27, 2024 11:52

build is failing

@Brunner246
Copy link
Contributor Author

@munterfi yeah it is a GCC version issue :(
i will update the build action asap with the latest compiler version => https://github.com/marketplace/actions/install-gcc

@Brunner246
Copy link
Contributor Author

@munterfi ping 🤖

@munterfi munterfi merged commit d8619e0 into main Aug 30, 2024
2 checks passed
@Brunner246 Brunner246 deleted the feature/NAV-160-create-gtfs-subset-writer-app branch August 30, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants