Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legg til sortering for Utgatt varsel-dato #1814

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

ingfo
Copy link
Contributor

@ingfo ingfo commented Dec 9, 2024

Describe your changes

  • Legg til sortering på dato i utgåtte varsel-hendelsar.
  • Bruker ein gyldig sorteringsverdi ("ikke_satt") i staden for ein ugyldig verdi ("asc") i testar der rekkefølgja ikkje speler nokon rolle.

Syster-PR: navikt/veilarbportefoljeflatefs#1164

Trello ticket number and link

https://trello.com/c/gK85yMHJ/835-sortering-p%C3%A5-kolonner-for-filterhendelse

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

@ingfo
Copy link
Contributor Author

ingfo commented Dec 9, 2024

@ingfo ingfo force-pushed the sortering-utgatt-varsel-dato branch from 00fa7b0 to 825141e Compare December 9, 2024 14:50
@ingfo ingfo marked this pull request as ready for review December 9, 2024 14:52
@ingfo ingfo requested a review from a team as a code owner December 9, 2024 14:52
sidan den vert oversatt til "SortOrder.DESC" i sorterQueryParametere() (linje 447)

Det same skjer med "ikke_satt", men då er det tydelegare at rekkefølgja ikkje speler nokon rolle. Vi skal få typesikra dette på sikt.
fordi enum ikkje er nok, og det hadde eg gløymd
@ingfo ingfo force-pushed the sortering-utgatt-varsel-dato branch from 825141e to 3627853 Compare December 10, 2024 09:14
@ingfo ingfo merged commit 989df5c into dev Dec 10, 2024
9 checks passed
@ingfo ingfo deleted the sortering-utgatt-varsel-dato branch December 10, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants