Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nye felter i søknad for alderspensjon #3737

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

krharum
Copy link
Contributor

@krharum krharum commented Feb 3, 2025

This pull request includes several changes to the dolly-backend application, focusing on improving the initialization process, enhancing the AlderspensjonSoknadRequest domain, and updating the PensjonAlderspensjonSoknadMappingStrategy mapping strategy. The most important changes are summarized below:

Application Initialization:

  • Modified DollyBackendApplicationStarter to use SpringApplicationBuilder with NaisEnvironmentApplicationContextInitializer for better environment configuration.

Domain Enhancements:

  • Added inkluderAfpPrivat and afpPrivatResultat fields to AlderspensjonSoknadRequest.
  • Introduced AfpPrivatResultat enum in PensjonData.Alderspensjon class. [1] [2]

Mapping Strategy Updates:

  • Added SecureRandom instance for generating random values in PensjonAlderspensjonSoknadMappingStrategy.
  • Updated isHarVaertGift and isVarigAdskilt methods to correct logic and use randomness.
  • Replaced .get(0) with .getFirst() for better readability and safety in mapAtoB method.

Dependency Management:

  • Imported PensjonData in AlderspensjonSoknadRequest to utilize the new fields and enum.…pensjon

@krharum krharum requested a review from a team as a code owner February 3, 2025 14:06
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

@krharum krharum merged commit dd03f08 into master Feb 12, 2025
326 checks passed
@krharum krharum deleted the feature/nye-felter-i-alderspensjonsoknad branch February 12, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants