Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ny dialog for bankId pålogging #3707

Merged
merged 18 commits into from
Jan 14, 2025

Conversation

krharum
Copy link
Contributor

@krharum krharum commented Dec 20, 2024

Legge til ny dialog når ting feiler ved bankId-pålogging i dolly-idporten

@betsytraran
Copy link
Contributor

Siste versjon pushet 20.12:
Har laget utkast til en modal som åpnes dersom response fra /altinn/organisasjoner er tom. Funksjon for å logge ut bruker er flyttet inn i modalen, og vil trigges når man lukker den.
Problemet er at når jeg tester på deployet versjon ser det ut til at man blir logget ut før man i det hele tatt kommer til testen som vil åpne modalen. Har foreløpig ikke klart å finne frem til hva som trigger utlogging såpass tidlig.

@krharum krharum marked this pull request as ready for review January 2, 2025 07:12
@krharum krharum requested a review from a team as a code owner January 2, 2025 07:12
@krharum krharum changed the title deploy Ny dialog for bankId pålogging Jan 2, 2025
@krharum krharum marked this pull request as draft January 2, 2025 07:25
krharum and others added 7 commits January 2, 2025 08:46
#deploy-idporten-frontend
#deploy-idporten-frontend

Revised the error message in ErrorModal to provide detailed instructions for resolving access issues with Dolly. Updated button text from "Tilbake" to "OK" for better clarity. Minor formatting adjustment in DollyFrontendApplicationStarter to fix missing newline at EOF.
…ontend

Corrected several typos in the ErrorModal component, including "organisajoner" to "organisasjoner" and adjusted phrasing for better readability. These changes enhance the user experience by providing clearer instructions and ensuring grammatical accuracy.
…ten-frontend

Replaced specific contact email with a group email for NAV communication and clarified support procedure. This ensures easier handling of requests and provides a central point of contact for support-related inquiries.
Enhanced wording and formatting to improve user comprehension. Added a line break and revised phrasing to provide clearer and more actionable support instructions.
Revised the support contact text to be clearer and more user-friendly. This ensures the message is more inviting and helpful for users seeking assistance.
@krharum krharum marked this pull request as ready for review January 10, 2025 09:42
Simplified the error modal by removing the general support email ([email protected]) and keeping only the primary contact information. This change ensures clearer instructions and reduces potential confusion for users.
Copy link
Contributor

@betsytraran betsytraran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supert 🤩

import logoutBruker from '@/components/utlogging/logoutBruker'

//TODO: Tilpass styling av modalen, lag en egen CSS og fjern bruk av slettModal
//TODO: Tilpass tekst i modalen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fjernes

@krharum krharum merged commit 90ca9ca into master Jan 14, 2025
167 checks passed
@krharum krharum deleted the feature/ny-dialog-for-banckid-pålogging branch January 14, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants