Returner tom liste dersom man får en 404 fra aareg #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannbm
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Om Aareg ikke finner en person, så får man en 404 feil. Siden den ikke ble catchet på noe vis av eksisterende kode, fikk man tilbake en 500 fra APIet. Det gjør at vi ikke kan differensiere mellom når en person ikke finnes, og når noe går galt rent teknisk. Det er ikke ønskelig.
Denne PRen returnerer heller en tom liste med arbeidsforhold om man får en 404 fra Aareg-integrasjonen, som gjør at vi kan vise riktig feilmelding.