Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreløpige aktivitetskort-id-er #78

Merged
merged 11 commits into from
Nov 6, 2023
Merged

Foreløpige aktivitetskort-id-er #78

merged 11 commits into from
Nov 6, 2023

Conversation

tu55eladd
Copy link
Contributor

@tu55eladd tu55eladd commented Oct 31, 2023 •
edited
Loading

  • Alltid opprett aktivitetskort-id hvis ikke finnes når man prøver å hente den ut via REST-API
  • Bruk advisory-lock på deltakelse-id (arena-id) på alle insert i aktivitet og forelopig_aktivitet_id tabellene
  • Fjerner fra id fra forelopig_aktivitet_id ved insert i aktivitet

@tu55eladd tu55eladd changed the title getOrCreate aktivitetskort arenaId Foreløpige aktivitetskort-id-er Oct 31, 2023
@tu55eladd tu55eladd marked this pull request as ready for review October 31, 2023 12:30
@tu55eladd tu55eladd requested a review from a team as a code owner October 31, 2023 12:30
tu55eladd
tu55eladd commented Nov 6, 2023
View reviewed changes
src/test/kotlin/no/nav/arena_tiltak_aktivitet_acl/services/AktivitetServiceTest.kt

class AktivitetServiceTest : StringSpec({
class AktivitetServiceTest : IntegrationTestBase() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.7% 98.7% Coverage
0.0% 0.0% Duplication

@holymaloney holymaloney merged commit f10624b into main Nov 6, 2023
3 checks passed
@holymaloney holymaloney deleted the getOrCreate-aktivitetskort-arenaId branch November 6, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holymaloney holymaloney holymaloney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tu55eladd @holymaloney