Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added frequencies of future verbs in action stats #155

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

ThijsVroegh
Copy link
Collaborator

@ThijsVroegh ThijsVroegh commented Dec 9, 2024

This pull request includes a change to the generate_action_analysis_results method in the orangecontrib/storynavigation/modules/actionanalysis.py file. The change involves updating the filtering criteria for story elements to include future tense verbs, so that the frequencies of future verbs are also shown in the action stats table.

Solves issue #154

  • Updated generate_action_analysis_results method to include 'FUTURE_VB' in the filtering criteria for story_navigator_tag.

@ThijsVroegh ThijsVroegh requested a review from eriktks December 9, 2024 08:23
@ThijsVroegh
Copy link
Collaborator Author

Hi @erik. This PR is very small; in case you find the time?

@ThijsVroegh ThijsVroegh requested a review from Copilot December 13, 2024 10:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Member

@eriktks eriktks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and indeed the words with the story_navigator_tag FUTURE_VB now appear in the output of the widget, which they previously did not. The code change does look reasonable to me. Thanks for making this update!

@ThijsVroegh ThijsVroegh merged commit 2e25cbb into master Jan 14, 2025
3 checks passed
@ThijsVroegh ThijsVroegh deleted the issue154 branch January 14, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants