Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added auxilary verbs to be highlighted as well when stopwords are not… #121

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

ThijsVroegh
Copy link
Collaborator

This PR solves issue #84, so that now the auxiliary verbs are also highlighted (both past and present) in the actions widget. This happens only when in the elements widget the option is selected to not remove the stopwords, otherwise these auxilary verbs will not be highlighted

Copy link
Member

@eriktks eriktks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the code and it works. The updates made are sensible. There is one more place in the code that refers to verbs: util.py line 295. It would be good to make the same change there. Then the PR can be merged.

Copy link
Member

@eriktks eriktks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is fine now. Thanks!

@ThijsVroegh ThijsVroegh merged commit 3cfb261 into master Oct 15, 2024
3 checks passed
@ThijsVroegh ThijsVroegh deleted the issue84 branch October 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants