Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

🎨[Design]: ν™”λ©΄ 1 - 앨범 λͺ©λ‘ UI μ™„μ„± #2

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

🎨[Design]: ν™”λ©΄ 1 - 앨범 λͺ©λ‘ UI μ™„μ„± #2

wants to merge 11 commits into from

Conversation

doyeonjeong
Copy link
Member

Simulator Screen Recording - iPhone 14 Pro - 2023-03-25 at 16 45 31

  • Dummy Dataλ₯Ό μ΄μš©ν•˜μ—¬ UI ꡬ쑰 μ™„μ„± μ‹œμΌ°μŠ΅λ‹ˆλ‹€!
  • 앨범 μƒ˜ν”Œμ΄λ―Έμ§€ κ°™μ€κ²Œ μ—†κΈΈλž˜ 지 폴더 λͺ‡κ°œ λ§Œλ“€μ–΄μ„œ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€
  • κ·Έλž˜μ„œ 파일이 λ§Žμ•„ λ³΄μ΄λŠ”λ° μ½”λ“œ μž‘μ—…ν•œ νŒŒμΌμ€ 3개 정도 μž…λ‹ˆλ‹€!

@doyeonjeong
πŸŽ‰ [Create]: Project init
1e5816a 
ν”„λ‘œμ νŠΈ 생성 및 μ½”λ“œ 베이슀둜 κ΅¬μ„±ν•˜κΈ° μœ„ν•œ ν”„λ‘œμ νŠΈ μ„€μ •
@doyeonjeong
πŸ› οΈ[Chore]: Set Navigation Controller
4990db0 
Root View Controller λ₯Ό λ‚΄λΉ„κ²Œμ΄μ…˜ 컨트둀러둜 λ³€κ²½
@doyeonjeong
βž•[Add]: Add SnapKit
7bc001c 
SPM μ‚¬μš©
@doyeonjeong
🎨[Design]: Add Navigation Title
66d3c5d 
SceneDelegateμ—μ„œ UINavigationBarAppearance 속성을 μ΄μš©ν•˜μ—¬ μ„€μ •
@doyeonjeong
🎨[Design]: Set Collection View UI
1d52c84 
Collection View  λ ˆμ΄μ•„μ›ƒ μ„€μ •
@doyeonjeong
βž•[Add]: Add Album Model
1d248fe 
nameκ³Ό count만 μ‘΄μž¬ν•˜λŠ” Album λͺ¨λΈ 객체 μž„μ‹œλ‘œ 생성
@doyeonjeong
πŸ’©[Poop]: for Pair Programming
472814a
@doyeonjeong
🎨[Design]: AlbumListView UI
97ba01f 
더미 데이터λ₯Ό μ΄μš©ν•œ μ•¨λ²”λ¦¬μŠ€νŠΈ νŽ˜μ΄μ§€ UI ꡬ쑰 μ™„μ„±
@doyeonjeong
βž•[Add]: Assets
a43e488 
- 앨범 λ°μ΄ν„°λ‘œ μ‚¬μš©ν•  사진 μΆ”κ°€
- μ•± μ•„μ΄μ½˜ μΆ”κ°€
@doyeonjeong
πŸ›[Fix]: Edit ViewController Name
52f15d0 
AlbumListViewController둜 λ³€κ²½
kangddong
kangddong previously approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@kangddong kangddong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€ ~!

doyeon/Album/Album/Sources/AlbumListCell.swift Outdated
// MARK: - Properties
static let identifier: String = String(describing: AlbumListCell.self)

var LastImage = UIImageView(frame: .zero)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

첫 κΈ€μžλ₯Ό λŒ€λ¬Έμžλ‘œ μ΄μœ κ°€ κΆκΈˆν•΄μš” ~!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•— γ…‹γ…‹ 넀이밍 κ³ λ―Όν•˜λ‹€κ°€ μ˜€νƒ€λ‚¬λ„€μš” μˆ˜μ •ν•˜κ² μŠ΅λ‹ˆλ‹€~!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ • 되면 resolve λˆŒλŸ¬μ£Όμ„Έμš” ~!

@doyeonjeong
♻️[Refactor]: μ „λ©΄ μˆ˜μ •
8518e8c 
- 가독성을 κ°œμ„  μ‹œμΌœλ΄€μŠ΅λ‹ˆλ‹€.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kangddong kangddong kangddong left review comments

@jeehge jeehge Awaiting requested review from jeehge

@DevVenusK DevVenusK Awaiting requested review from DevVenusK

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doyeonjeong @kangddong