Add ItemStreamReaderProcessor interfaces #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbyungjun
commented
Oct 21, 2024
| .<Integer, Integer>chunk(chunkCount, new ResourcelessTransactionManager()) | ||
| .reader(itemStreamReader(testTasklet)) | ||
| .processor(itemProcessor(testTasklet)) | ||
| .writer(emptyItemStreamWriter) |
There was a problem hiding this comment.
SimpleStepBuilder requires both reader and writer, I added no operation writer in integration tests.
acktsap
reviewed
Oct 22, 2024
| * A {@link Flux<I>} based adapter for stream reader, processor. It can represent | ||
| * {@link ItemStreamReader}, {@link ItemProcessor} in a single class. | ||
| * | ||
| * @since 1.1.1 |
There was a problem hiding this comment.
It will be 1.2.0. Could you change to 1.2.0?
There was a problem hiding this comment.
Sorry for late response. Fixed in commit 5be1222
acktsap
approved these changes
Nov 14, 2024
|
Thank you for your contribution~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resovle #114
Add adapters for reader-processor pair. There are four new interfaces.
I think the integration test for reader-processor-writer is a super set of reader-processor.
So I thought about whether I would need a test, but I ended up adding it in a format that's almost the same as the existing integration test.