Change yaml parser to yamlbeans #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donggyu04
reviewed
Jan 8, 2024
| @@ -278,25 +278,26 @@ public Set<GitHubConfig> getAllGitHubConfig(User user) throws FileNotFoundExcept | |||
| return getAllGithubConfig(gitConfigYaml); | |||
| } | |||
|
|
|||
| private Set<GitHubConfig> getAllGithubConfig(FileEntry gitConfigYaml) { | |||
| protected Set<GitHubConfig> getAllGithubConfig(FileEntry gitConfigYaml) { | |||
There was a problem hiding this comment.
Why modifier was changed?
There was a problem hiding this comment.
I was changed it for adding a unit test. But, it doesn't need to change access modifier.
I will change it back to private and add a unit test to verify that successfully parse the .gitconfig.yml file.
donggyu04
previously approved these changes
Jan 8, 2024
imbyungjun
force-pushed
the
feature/yaml-reader
branch
from
36c3093
to
bd51284
Compare
|
❌ Build & Test workflow failed ❌ |
donggyu04
reviewed
Jan 9, 2024
|
|
||
| @Before | ||
| public void before() throws IOException { | ||
| File file = new File(System.getProperty("java.io.tmpdir"), "repo"); |
There was a problem hiding this comment.
How about use Junit TempDir?
It will be deleted automatically after test
There was a problem hiding this comment.
We are using junit 4.13.1 😭. And TempDir seems to be supported since Junit5.
Line 4 in f6d0672
I tried to use TempDir but it fails to get temp directory file via
@TempDir annotation.
donggyu04
approved these changes
Jan 9, 2024
imbyungjun
added a commit
that referenced
this pull request
May 14, 2024
This reverts commit 1a28741.
imbyungjun
added a commit
that referenced
this pull request
May 14, 2024
This reverts commit 1a28741.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snakeyaml 1.x has security vulnerability. So, I tried to bump it up to 2.x. But, the snakeyaml is related to spring framework also. When the snakeyaml is found on classpath, spring try to use the given snakeyaml to handling yaml property file.
Most of spring-boot versions are depend on snakeyaml 1.x except latest version of spring-boot. I think that upgrade spring-boot to latest version will take long time. So, just change the yaml parser to yamlbeans that has most stars library in yaml official website except snakeyaml.