Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use snakeyaml with SafeConstructor #1018

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

imbyungjun
Copy link
Contributor

Revert commit to use snakeyaml again.
And change to use SafeConstructor.

@imbyungjun imbyungjun requested a review from donggyu04 May 14, 2024 18:10
@imbyungjun imbyungjun self-assigned this May 14, 2024

gitHubConfig.add(config);
// Yaml is not thread safe. so create it every time.
Yaml yaml = new Yaml(new SafeConstructor());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the one thing that changed is here. Use the SafeConstructor.

Copy link

❌ Build & Test workflow failed ❌

@imbyungjun imbyungjun merged commit cac2c82 into develop May 16, 2024
4 of 6 checks passed
@imbyungjun imbyungjun deleted the feature/yaml branch May 16, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant