Fix script validation error on docker env #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build & Test workflow failed ❌ |
imbyungjun
commented
Feb 27, 2024
| @@ -205,7 +204,7 @@ public String buildJVMArgumentWithoutMemory() { | |||
| addAdditionalJavaOpt(jvmArguments); | |||
| } | |||
|
|
|||
| String jdkVersion = getJDKVersion(); | |||
| String jdkVersion = System.getProperty("java.specification.version"); | |||
There was a problem hiding this comment.
getJDKVersion() method called only here. And it is not related with Oshi �unlike the other methods. So, remove the method and change to check system property here directly.
There was a problem hiding this comment.
This change also make Script Validation function doesn't depends on SystemInfoUtils. So, I expect that NoClassDefFoundError does not occur anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #940
This issue seems like ohsi error that is occurred in docker container env only.
Currently, base JDK version is changed to 11. So, updated oshi version to work with JDK 11.
And expect this change will fix the oshi issue also.