Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix threshold option not applying snap threshold #845

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

malangfox
Copy link
Contributor

Issue

#844

Details

  • When determining the snapThreshold in _calcSnapThreshold, the value of the threshold option for the Flicking instance must be applied.
  • We didn't have a unit test that used vertical Flicking (DEFAULT_VERTICAL in a unit test) and this is the first time we've used it, I fixed it to be similar to the Flicking for other tests.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


malangfox seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

Coverage Status

coverage: 82.661% (+0.02%) from 82.638%
when pulling 39b1edd on malangfox:fix-vertical-threshold
into 3d52804 on naver:master.

Copy link
Member

@daybrush daybrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malangfox malangfox merged commit cf1636e into naver:master Mar 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants