fix: fix flicking setter error

naver · May 31, 2024 · 18c4a74 · 18c4a74
1 parent 40bc122
commit 18c4a74
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 5 deletions.
diff --git a/packages/ngx-flicking/projects/ngx-flicking/src/lib/ngx-flicking.component.ts b/packages/ngx-flicking/projects/ngx-flicking/src/lib/ngx-flicking.component.ts
@@ -216,7 +216,10 @@ export class NgxFlickingComponent
     // Omit 'virtual', as it can't have any setter
     for (const key in newOptions) {
       if (key in flicking && flicking[key] !== newOptions[key]) {
-        flicking[key] = newOptions[key];
+        try {
+          flicking[key] = newOptions[key];
+        // eslint-disable-next-line no-empty
+        } catch (e) {}
       }
     }
 

diff --git a/packages/react-flicking/src/react-flicking/Flicking.tsx b/packages/react-flicking/src/react-flicking/Flicking.tsx
@@ -140,7 +140,9 @@ class Flicking extends React.Component<Partial<FlickingProps & FlickingOptions>>
     const { virtual, ...props } = this.props;
     for (const key in props) {
       if (key in flicking && flicking[key] !== props[key]) {
-        flicking[key] = props[key];
+        try {
+          flicking[key] = props[key];
+        } catch (e) {}
       }
     }
 

diff --git a/packages/svelte-flicking/src/flicking.svelte b/packages/svelte-flicking/src/flicking.svelte
@@ -69,7 +69,9 @@
       // Omit 'virtual', as it can't have any setter
       for (const key in newOptions) {
         if (key in vanillaFlicking && vanillaFlicking[key] !== newOptions[key]) {
-          vanillaFlicking[key] = newOptions[key];
+          try {
+            vanillaFlicking[key] = newOptions[key];
+          } catch (e) {}
         }
       }
     }

diff --git a/packages/vue-flicking/src/Flicking.ts b/packages/vue-flicking/src/Flicking.ts
@@ -217,7 +217,10 @@ const Flicking = Vue.extend({
 
         for (const key in options) {
           if (key in flicking && flicking[key] !== options[key]) {
-            flicking[key] = options[key];
+            try {
+              flicking[key] = options[key];
+            // eslint-disable-next-line no-empty
+            } catch (e) {}
           }
         }
       },

diff --git a/packages/vue3-flicking/src/Flicking.ts b/packages/vue3-flicking/src/Flicking.ts
@@ -259,7 +259,10 @@ const Flicking = defineComponent({
 
         for (const key in options) {
           if (key in flicking && flicking[key] !== options[key]) {
-            flicking[key] = options[key];
+            try {
+              flicking[key] = options[key];
+            // eslint-disable-next-line no-empty
+            } catch (e) {}
           }
         }
       },