Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLEANUP: Protected visibility in final class #824

Merged
merged 1 commit into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public final class BTreeFindPositionOperationImpl extends OperationImpl implemen
private static final OperationStatus NOT_FOUND_ELEMENT = new CollectionOperationStatus(
false, "NOT_FOUND_ELEMENT", CollectionResponse.NOT_FOUND_ELEMENT);

protected final String key;
protected final BTreeFindPosition get;
private final String key;
private final BTreeFindPosition get;

public BTreeFindPositionOperationImpl(String key, BTreeFindPosition get,
OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,21 +56,21 @@ public final class BTreeFindPositionWithGetOperationImpl extends OperationImpl i
private static final OperationStatus NOT_FOUND_ELEMENT = new CollectionOperationStatus(
false, "NOT_FOUND_ELEMENT", CollectionResponse.NOT_FOUND_ELEMENT);

protected final String key;
protected final BTreeFindPositionWithGet get;

protected int position = 0;
protected int flags = 0;
protected int count = 0;
protected int index = 0;
protected int pos = 0;
protected int posDiff = 0;
protected byte[] data = null;
protected int readOffset = 0;
protected byte lookingFor = '\0';
protected final List<String> tokens = new ArrayList<>();
protected int eHeadCount;
protected int eFlagIndex;
private final String key;
private final BTreeFindPositionWithGet get;

private int position = 0;
private int flags = 0;
private int count = 0;
private int index = 0;
private int pos = 0;
private int posDiff = 0;
private byte[] data = null;
private int readOffset = 0;
private byte lookingFor = '\0';
private final List<String> tokens = new ArrayList<>();
private int eHeadCount;
private int eFlagIndex;

public BTreeFindPositionWithGetOperationImpl(String key, BTreeFindPositionWithGet get,
OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,16 @@ public final class BTreeGetBulkOperationImpl extends OperationImpl implements
private static final OperationStatus UNREADABLE = new CollectionOperationStatus(
false, "UNREADABLE", CollectionResponse.UNREADABLE);

protected final BTreeGetBulk<?> getBulk;
private final BTreeGetBulk<?> getBulk;

protected String key;
protected int flags = 0;
protected int elementCount = 0;
private String key;
private int flags = 0;
private int elementCount = 0;

protected byte[] data = null;
protected int readOffset = 0;
protected byte lookingFor = '\0';
protected int spaceCount = 0;
private byte[] data = null;
private int readOffset = 0;
private byte lookingFor = '\0';
private int spaceCount = 0;

public BTreeGetBulkOperationImpl(BTreeGetBulk<?> getBulk, OperationCallback cb) {
super(cb);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,19 @@ public final class BTreeGetByPositionOperationImpl extends OperationImpl impleme
private static final OperationStatus NOT_FOUND_ELEMENT = new CollectionOperationStatus(
false, "NOT_FOUND_ELEMENT", CollectionResponse.NOT_FOUND_ELEMENT);

protected final String key;
protected final BTreeGetByPosition get;

protected int flags = 0;
protected int count = 0;
protected int pos = 0;
protected int posDiff = 0;
protected byte[] data = null;
protected int readOffset = 0;
protected byte lookingFor = '\0';
protected final List<String> tokens = new ArrayList<>();
protected int eHeadCount;
protected int eFlagIndex;
private final String key;
private final BTreeGetByPosition get;

private int flags = 0;
private int count = 0;
private int pos = 0;
private int posDiff = 0;
private byte[] data = null;
private int readOffset = 0;
private byte lookingFor = '\0';
private final List<String> tokens = new ArrayList<>();
private int eHeadCount;
private int eFlagIndex;

public BTreeGetByPositionOperationImpl(String key, BTreeGetByPosition get,
OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,18 @@ public final class BTreeInsertAndGetOperationImpl extends OperationImpl implemen

private static final OperationStatus[] STORE_AND_GET_ON_DATA = {TRIMMED};

protected final String key;
protected final BTreeInsertAndGet<?> get;
protected final byte[] dataToStore;

protected int flags = 0;
protected int count = 0;
protected byte[] data = null;
protected int readOffset = 0;
protected byte lookingFor = '\0';
protected final List<String> tokens = new ArrayList<>();
protected int eHeadCount;
protected int eFlagIndex;
private final String key;
private final BTreeInsertAndGet<?> get;
private final byte[] dataToStore;

private int flags = 0;
private int count = 0;
private byte[] data = null;
private int readOffset = 0;
private byte lookingFor = '\0';
private final List<String> tokens = new ArrayList<>();
private int eHeadCount;
private int eFlagIndex;

public BTreeInsertAndGetOperationImpl(String key, BTreeInsertAndGet<?> get,
byte[] dataToStore, OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,16 @@ public final class BTreeSortMergeGetOperationImpl extends OperationImpl implemen
private static final OperationStatus BKEY_MISMATCH = new CollectionOperationStatus(
false, "BKEY_MISMATCH", CollectionResponse.BKEY_MISMATCH);

protected final BTreeSMGet<?> smGet;
private final BTreeSMGet<?> smGet;

protected int flags = 0;
protected int lineCount = 0;
protected byte[] data = null;
protected int readOffset = 0;
protected byte lookingFor = '\0';
protected int spaceCount = 0;
private int flags = 0;
private int lineCount = 0;
private byte[] data = null;
private int readOffset = 0;
private byte lookingFor = '\0';
private int spaceCount = 0;

protected ReadState readState = ReadState.VALUE;
private ReadState readState = ReadState.VALUE;

public BTreeSortMergeGetOperationImpl(BTreeSMGet<?> smGet,
OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@ public final class BTreeSortMergeGetOperationOldImpl extends OperationImpl imple
private static final OperationStatus BKEY_MISMATCH = new CollectionOperationStatus(
false, "BKEY_MISMATCH", CollectionResponse.BKEY_MISMATCH);

protected final BTreeSMGet<?> smGet;
private final BTreeSMGet<?> smGet;

protected int flags = 0;
protected int count = 0;
protected byte[] data = null;
protected int readOffset = 0;
protected byte lookingFor = '\0';
protected int spaceCount = 0;
private int flags = 0;
private int count = 0;
private byte[] data = null;
private int readOffset = 0;
private byte lookingFor = '\0';
private int spaceCount = 0;

protected int readState = 0; // 0 : value, 1 : missed keys
private int readState = 0; // 0 : value, 1 : missed keys

public BTreeSortMergeGetOperationOldImpl(BTreeSMGet<?> smGet,
OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ public final class CollectionBulkInsertOperationImpl extends OperationImpl
private static final OperationStatus BKEY_MISMATCH = new CollectionOperationStatus(
false, "BKEY_MISMATCH", CollectionResponse.BKEY_MISMATCH);

protected final CollectionBulkInsert<?> insert;
protected final CollectionBulkInsertOperation.Callback cb;
private final CollectionBulkInsert<?> insert;
private final CollectionBulkInsertOperation.Callback cb;

protected int count;
protected int index = 0;
protected boolean successAll = true;
private int count;
private int index = 0;
private boolean successAll = true;

public CollectionBulkInsertOperationImpl(CollectionBulkInsert<?> insert, OperationCallback cb) {
super(cb);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ public final class CollectionCountOperationImpl extends OperationImpl implements
private static final OperationStatus UNREADABLE = new CollectionOperationStatus(
false, "UNREADABLE", CollectionResponse.UNREADABLE);

protected final String key;
protected final CollectionCount collectionCount;
private final String key;
private final CollectionCount collectionCount;

protected int count = 0;
private int count = 0;

public CollectionCountOperationImpl(String key,
CollectionCount collectionCount, OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ public final class CollectionCreateOperationImpl extends OperationImpl
private static final OperationStatus SERVER_ERROR = new CollectionOperationStatus(
false, "SERVER_ERROR", CollectionResponse.SERVER_ERROR);

protected final String key;
protected final CollectionCreate collectionCreate;
private final String key;
private final CollectionCreate collectionCreate;

public CollectionCreateOperationImpl(String key,
CollectionCreate collectionCreate, OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ public final class CollectionDeleteOperationImpl extends OperationImpl
private static final OperationStatus BKEY_MISMATCH = new CollectionOperationStatus(
false, "BKEY_MISMATCH", CollectionResponse.BKEY_MISMATCH);

protected String key;
protected CollectionDelete collectionDelete;
private String key;
private CollectionDelete collectionDelete;

public CollectionDeleteOperationImpl(String key,
CollectionDelete collectionDelete, OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ public final class CollectionExistOperationImpl extends OperationImpl
private static final OperationStatus UNREADABLE = new CollectionOperationStatus(
false, "UNREADABLE", CollectionResponse.UNREADABLE);

protected final String key;
protected final String subkey;
protected final CollectionExist collectionExist;
private final String key;
private final String subkey;
private final CollectionExist collectionExist;

public CollectionExistOperationImpl(String key, String subkey,
CollectionExist collectionExist, OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,17 @@ public final class CollectionGetOperationImpl extends OperationImpl
private static final OperationStatus UNREADABLE = new CollectionOperationStatus(
false, "UNREADABLE", CollectionResponse.UNREADABLE);

protected final String key;
protected final CollectionGet collectionGet;

protected int flags = 0;
protected int count = 0;
protected byte[] data = null;
protected int readOffset = 0;
protected byte lookingFor = '\0';
protected final List<String> tokens = new ArrayList<>();
protected int eHeadCount;
protected int eFlagIndex;
private final String key;
private final CollectionGet collectionGet;

private int flags = 0;
private int count = 0;
private byte[] data = null;
private int readOffset = 0;
private byte lookingFor = '\0';
private final List<String> tokens = new ArrayList<>();
private int eHeadCount;
private int eFlagIndex;

public CollectionGetOperationImpl(String key, CollectionGet collectionGet,
OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ public final class CollectionInsertOperationImpl extends OperationImpl
private static final OperationStatus BKEY_MISMATCH = new CollectionOperationStatus(
false, "BKEY_MISMATCH", CollectionResponse.BKEY_MISMATCH);

protected final String key;
protected final String subkey; // e.g.) 0 or 0x00
protected final CollectionInsert<?> collectionInsert;
protected final byte[] data;
private final String key;
private final String subkey; // e.g.) 0 or 0x00
private final CollectionInsert<?> collectionInsert;
private final byte[] data;

public CollectionInsertOperationImpl(String key, String subkey,
CollectionInsert<?> collectionInsert, byte[] data,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ public final class CollectionMutateOperationImpl extends OperationImpl implement
private static final OperationStatus OUT_OF_RANGE = new CollectionOperationStatus(
false, "OUT_OF_RANGE", CollectionResponse.OUT_OF_RANGE);

protected final String key;
protected final String subkey;
protected final CollectionMutate collectionMutate;
private final String key;
private final String subkey;
private final CollectionMutate collectionMutate;

public CollectionMutateOperationImpl(String key, String subkey,
CollectionMutate collectionMutate, OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ public final class CollectionPipedExistOperationImpl extends OperationImpl imple
private static final OperationStatus UNREADABLE = new CollectionOperationStatus(
false, "UNREADABLE", CollectionResponse.UNREADABLE);

protected final String key;
protected final SetPipedExist<?> setPipedExist;
protected final CollectionPipedExistOperation.Callback cb;
private final String key;
private final SetPipedExist<?> setPipedExist;
private final CollectionPipedExistOperation.Callback cb;

protected int count;
protected int index = 0;
protected boolean successAll = true;
private int count;
private int index = 0;
private boolean successAll = true;

public CollectionPipedExistOperationImpl(String key,
SetPipedExist<?> collectionExist, OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,13 @@ public final class CollectionPipedInsertOperationImpl extends OperationImpl
private static final OperationStatus BKEY_MISMATCH = new CollectionOperationStatus(
false, "BKEY_MISMATCH", CollectionResponse.BKEY_MISMATCH);

protected final String key;
protected final CollectionPipedInsert<?> insert;
protected final CollectionPipedInsertOperation.Callback cb;
private final String key;
private final CollectionPipedInsert<?> insert;
private final CollectionPipedInsertOperation.Callback cb;

protected int count;
protected int index = 0;
protected boolean successAll = true;
private int count;
private int index = 0;
private boolean successAll = true;

public CollectionPipedInsertOperationImpl(String key,
CollectionPipedInsert<?> insert, OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ public final class CollectionPipedUpdateOperationImpl extends OperationImpl impl
private static final OperationStatus SERVER_ERROR = new CollectionOperationStatus(
false, "SERVER_ERROR", CollectionResponse.SERVER_ERROR);

protected final String key;
protected final CollectionPipedUpdate<?> update;
protected final CollectionPipedUpdateOperation.Callback cb;
private final String key;
private final CollectionPipedUpdate<?> update;
private final CollectionPipedUpdateOperation.Callback cb;

protected int count;
protected int index = 0;
protected boolean successAll = true;
private int count;
private int index = 0;
private boolean successAll = true;

public CollectionPipedUpdateOperationImpl(String key,
CollectionPipedUpdate<?> update, OperationCallback cb) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@ public final class CollectionUpdateOperationImpl extends OperationImpl implement
private static final OperationStatus SERVER_ERROR = new CollectionOperationStatus(
false, "SERVER_ERROR", CollectionResponse.SERVER_ERROR);

protected final String key;
protected final String subkey; // e.g.) 0 or 0x00
protected final CollectionUpdate<?> collectionUpdate;
protected final byte[] data;
private final String key;
private final String subkey; // e.g.) 0 or 0x00
private final CollectionUpdate<?> collectionUpdate;
private final byte[] data;

public CollectionUpdateOperationImpl(String key, String subkey,
CollectionUpdate<?> collectionUpdate, byte[] data,
Expand Down