Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERNAL: Make final class which is not inherit #823

Merged
merged 1 commit into from
Oct 10, 2024
Merged

INTERNAL: Make final class which is not inherit #823

merged 1 commit into from
Oct 10, 2024

Conversation

cheesecrust
Copy link
Collaborator

@cheesecrust cheesecrust commented Oct 2, 2024 •
edited
Loading

πŸ”— Related Issue

⌨️ What I did

상속이 ν•„μš”μ—†λŠ” ν΄λž˜μŠ€μ— λŒ€ν•΄ final 클래슀둜 λ§Œλ“­λ‹ˆλ‹€.

CacheMonitor, MigrationMonitor, MemcachedReplicationGroupImpl, CacheManager, ArcusReplNodeAddress, MemcachedNodeROImpl, MemcachedReplicaGroupImpl, MemcachedReplicaGroupROImpl` ν΄λž˜μŠ€λ“€μ„ final 둜 λ³€κ²½ν•©λ‹ˆλ‹€.

@cheesecrust cheesecrust force-pushed the internal/invoke-method branch 2 times, most recently from c447ec4 to c9acd2a Compare October 7, 2024 07:10
@cheesecrust cheesecrust changed the title INTERNAL: Divide method from constuctor which pass for parm method INTERNAL: Make final class to solve this-escape Oct 7, 2024
@cheesecrust cheesecrust force-pushed the internal/invoke-method branch 2 times, most recently from de994aa to dde7f04 Compare October 7, 2024 07:13
@oliviarla
Copy link
Collaborator

@cheesecrust
PR 성격 자체λ₯Ό "상속이 ν•„μš”μ—†λŠ” ν΄λž˜μŠ€μ— λŒ€ν•΄ final 클래슀둜 λ§Œλ“ λ‹€" 둜 λ³€κ²½ν•˜κ³ , final을 달아도 λ˜κ² λ‹€κ³  μƒκ°λ˜λŠ” ν΄λž˜μŠ€λ“€μ„ μ½”λ©˜νŠΈλ‘œ λ‹¬μ•„μ£Όμ„Έμš”. μ§€κΈˆμ€ spy.memcached νŒ¨ν‚€μ§€λ§Œ κ²€ν† ν•˜λ©΄ 될 것 κ°™μŠ΅λ‹ˆλ‹€.

μ½”λ©˜νŠΈλ₯Ό 보고 변경해도 λ λ§Œν•œ ν΄λž˜μŠ€μΈμ§€ μ €λ‚˜ λ‹€λ₯Έ 뢄이 κ²€μ¦λœ 후에 μ½”λ“œ μˆ˜μ •ν•΄μ£Όμ‹œλ©΄ 될 것 κ°™μŠ΅λ‹ˆλ‹€.

@cheesecrust cheesecrust marked this pull request as draft October 7, 2024 08:34
@cheesecrust cheesecrust changed the title INTERNAL: Make final class to solve this-escape INTERNAL: Make final class which is not inherit Oct 7, 2024
@jhpark816
Copy link
Collaborator

@oliviarla
λ³Έ PR의 처음 μ½”λ©˜νŠΈμ— λͺ…μ‹œν•œ ν΄λž˜μŠ€λ“€μ΄
final class λ°©μ‹μœΌλ‘œ lint μ›Œλ‹μ„ ν•΄κ²°ν•  클래슀 λͺ©λ‘μ΄λΌκ³  μƒκ°λ©λ‹ˆλ‹€.

@oliviarla
Copy link
Collaborator

@jhpark816
lint μ›Œλ‹ λ°œμƒν•˜λŠ” 클래슀 이외에도 final둜 λ‘˜ 수 μžˆλŠ” 클래슀라면 final둜 λ³€κ²½ν•˜λŠ” μž‘μ—…μ„ ν•˜κ³ μž ν•©λ‹ˆλ‹€.

@jhpark816
Copy link
Collaborator

@oliviarla
OK. μ˜λ„λ₯Ό μ•Œκ² μŠ΅λ‹ˆλ‹€.

@cheesecrust
Copy link
Collaborator Author

@oliviarla
spy.memcached package μ—μ„œ μ•„λž˜μ˜ class 듀을 μΆ”κ°€μ μœΌλ‘œ final 둜 변경해도 될 것 κ°™μŠ΅λ‹ˆλ‹€.

ArcusReplNodeAddress
CacheMap
CASMutator
CASValue
MemcachedNodeROImpl
MemcachedReplicaGroupImpl
MemcachedReplicaGroupROImpl
PartitionedList
PartitionedMap
StatisticsHandler

@jhpark816
Copy link
Collaborator

@oliviarla
λ³Έ PR 외에 μ•„λž˜λ§Œ final class둜 μΆ”κ°€ν•˜λŠ” 것은 μ–΄λ–€κ°€μš”?

ArcusReplNodeAddress
MemcachedNodeROImpl
MemcachedReplicaGroupImpl
MemcachedReplicaGroupROImpl

@oliviarla
Copy link
Collaborator

@cheesecrust
@jhpark816 λ‹˜μ΄ λ§μ”€ν•˜μ‹  λ„€ 가지 ν΄λž˜μŠ€μ—λ§Œ final 적용 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€!

@cheesecrust cheesecrust marked this pull request as ready for review October 10, 2024 05:27
@cheesecrust
Copy link
Collaborator Author

@oliviarla
λ°˜μ˜ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

@jhpark816 jhpark816 merged commit 25bac40 into naver:develop Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviarla oliviarla oliviarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheesecrust @oliviarla @jhpark816