Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Divide thread method from constructor #821

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

cheesecrust
Copy link
Collaborator

πŸ”— Related Issue

⌨️ What I did

  • final class κ°€ μ•„λ‹Œ class 의 μƒμ„±μžμ—μ„œ thread의 λ©”μ„œλ“œ λ₯Ό ν˜ΈμΆœν•˜μ—¬ this-escape warning 이 λ°œμƒν•©λ‹ˆλ‹€. λ”°λΌμ„œ 이λ₯Ό ν”Όν•˜κΈ° μœ„ν•΄ μƒμ„±μžκ°€ μ•„λ‹Œ μƒμ„±μžλ₯Ό ν˜ΈμΆœν•˜λŠ” κ³³μ—μ„œ thread 의 λ©”μ„œλ“œλ₯Ό λ”°λ‘œ ν˜ΈμΆœν•˜λ„λ‘ ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

https://www.baeldung.com/java-thread-constructor
https://stackoverflow.com/questions/5623285/why-not-to-start-a-thread-in-the-constructor-how-to-terminate

oliviarla
oliviarla previously approved these changes Sep 30, 2024
@jhpark816
Copy link
Collaborator

@oliviarla μ΅œμ’… λ¦¬λ·°ν•˜μ‹œμ£ .

@jhpark816 jhpark816 merged commit 0861950 into naver:develop Oct 2, 2024
3 checks passed
@cheesecrust cheesecrust deleted the internal/thread-start branch October 8, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants