Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Remove public modifier in test method #819

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

cheesecrust
Copy link
Collaborator

@cheesecrust cheesecrust commented Sep 27, 2024

πŸ”— Related Issue

⌨️ What I did

  • Junit3 μ—μ„œ μ‘΄μž¬ν•˜λ˜ ν…ŒμŠ€νŠΈ λ©”μ„œλ“œ μ ‘κ·Όμ œν•œμž κ·œμΉ™μ΄ Junit5 μ—μ„œ 사라짐에 따라 λΆˆν•„μš”ν•œ μ ‘κ·Όμ œμ–΄μžλ₯Ό μ œκ±°ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

λ³€κ²½ ν›„ test 개수 905 개둜 λ™μΌν•©λ‹ˆλ‹€

@oliviarla
Copy link
Collaborator

@cheesecrust
남은 λΆ€λΆ„ ν•œκΊΌλ²ˆμ— μ˜¬λ €λ„ 리뷰에 문제 없을 것 κ°™μŠ΅λ‹ˆλ‹€.

@oliviarla
Copy link
Collaborator

@cheesecrust
ProtocolBaseCase/CancellationBaseCase 클래슀 μžμ²΄μ™€ λ‚΄λΆ€ ν…ŒμŠ€νŠΈ λ©”μ„œλ“œλ“€μ—μ„œ public μ œκ±°ν•˜κ³ , 이λ₯Ό μƒμ†λ°›λŠ” μͺ½μ—μ„œλ„ public μ œκ±°ν•˜κ³ , AsciiIPV6ClientTest, AsciiCancellationTest 같은 μžμ‹ ν΄λž˜μŠ€λ“€λ„ public μ œκ±°ν•΄λ„ 될 것 κ°™μŠ΅λ‹ˆλ‹€.
public은 ν…ŒμŠ€νŠΈ 지원을 μœ„ν•œ ν΄λž˜μŠ€λ‚˜ 읡λͺ… 클래슀 κ΅¬ν˜„ λ“±μ—λ§Œ μ μš©λ˜λ„λ‘ ν™•μΈν•΄μ£Όμ„Έμš”.

@cheesecrust cheesecrust marked this pull request as draft September 30, 2024 06:17
@cheesecrust cheesecrust force-pushed the internal/test-public branch 2 times, most recently from f1dce45 to 1f15ca4 Compare September 30, 2024 06:19
@cheesecrust
Copy link
Collaborator Author

@cheesecrust ProtocolBaseCase/CancellationBaseCase 클래슀 μžμ²΄μ™€ λ‚΄λΆ€ ν…ŒμŠ€νŠΈ λ©”μ„œλ“œλ“€μ—μ„œ public μ œκ±°ν•˜κ³ , 이λ₯Ό μƒμ†λ°›λŠ” μͺ½μ—μ„œλ„ public μ œκ±°ν•˜κ³ , AsciiIPV6ClientTest, AsciiCancellationTest 같은 μžμ‹ ν΄λž˜μŠ€λ“€λ„ public μ œκ±°ν•΄λ„ 될 것 κ°™μŠ΅λ‹ˆλ‹€. public은 ν…ŒμŠ€νŠΈ 지원을 μœ„ν•œ ν΄λž˜μŠ€λ‚˜ 읡λͺ… 클래슀 κ΅¬ν˜„ λ“±μ—λ§Œ μ μš©λ˜λ„λ‘ ν™•μΈν•΄μ£Όμ„Έμš”.

μƒμ†λ°›λŠ” μžμ‹ ν΄λž˜μŠ€λ“€μ˜ public μ ‘κ·Όμ œμ–΄μžλ₯Ό μ œκ±°ν–ˆκ³ , λ‹€λ₯Έ νŒ¨ν‚€μ§€μ˜ ν΄λž˜μŠ€μ— μƒμ†ν•˜λŠ” 클래슀λ₯Ό μ œμ™Έν•˜κ³ λŠ” public 을 μ œκ±°ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

@cheesecrust cheesecrust marked this pull request as ready for review September 30, 2024 06:21
@jhpark816 jhpark816 merged commit a453ff9 into naver:develop Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants