Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Update MAX_KEYS_FOR_MULTI_STORE_OPERATION from 200 to 500 #310

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

namsic
Copy link
Collaborator

@namsic namsic commented Aug 30, 2024

MAX_KEYS_FOR_MULTI_STORE_OPERATION 값을 조정합니다.

@namsic namsic requested a review from jhpark816 August 30, 2024 08:17
@jhpark816
Copy link
Contributor

@namsic
CI 확인해 주세요.

@@ -5,7 +5,7 @@ using namespace libtest;

#include "tests/storage.h"

#define REQ_COUNT MAX_KEYS_FOR_MULTI_STORE_OPERATION
#define REQ_COUNT 100
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/storage.cc: In function ‘bool do_mappend_and_get(memcached_st*, bool)’:
tests/storage.cc:530:1: error: the frame size of 58032 bytes is larger than 32768 bytes [-Werror=frame-larger-than=]
  530 | }
      | ^
tests/storage.cc: In function ‘bool do_mprepend_and_get(memcached_st*, bool)’:
tests/storage.cc:435:1: error: the frame size of 58032 bytes is larger than 32768 bytes [-Werror=frame-larger-than=]
  435 | }
      | ^
tests/storage.cc: In function ‘bool do_mcas_and_get(memcached_st*, bool)’:
tests/storage.cc:675:1: error: the frame size of 70176 bytes is larger than 32768 bytes [-Werror=frame-larger-than=]
  675 | }
      | ^
At global scope:
cc1plus: error: unrecognized command line option ‘-Wno-nested-anon-types’ [-Werror]

REQ_COUNT는 아래와 같이 사용하고 있는데, 로컬 변수 크기 때문에 문제 발생하는 듯 하여 수치를 조정했습니다.

static bool do_mappend_and_get(memcached_st *mc, bool is_noreply)
{
  memcached_storage_request_st set_req[REQ_COUNT];
  memcached_storage_request_st append_req[REQ_COUNT];

@jhpark816 jhpark816 requested a review from uhm0311 August 30, 2024 10:50
@jhpark816
Copy link
Contributor

@uhm0311 리뷰 바랍니다.

@jhpark816 jhpark816 merged commit a83bbe4 into naver:develop Aug 30, 2024
1 check passed
@namsic namsic deleted the 65-MT_ST_OP branch August 30, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants