-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Add proxy_lock_count for multiple proxy in a process #309
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아래와 같이 proxy_lock_count 값 접근 시에만 lock 잡는 코드이면 충분하지 않나요?
그리고, multi-process 환경이더라도
do_arcus_proxy_create() 호출하는 process는 parent process일 것으로 보이고,
Parent process가 single thread이면 do_arcus_proxy_create()는 순차적으로 호출될 것 같습니다.
그러면, proxy_lock_mtx도 필요 없지 않는 지 ?
어떻게 생각하나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
원래는
proc_mutex_create()
에 실패하는 경우proxy_lock_count
를 다시 원복시키려고 했습니다.생각해 보니 굳이
proxy_lock_count
를 되돌리지 않아도 문제가 없을 듯 하여 관련 코드를 제거했는데, lock 조정하는 것을 미처 생각하지 못했습니다.process는 여러 thread를 가질 수 있으므로 전역 변수는 당연히 lock을 잡고 수정해야 한다고 막연히 생각했는데,
말씀을 듣고 보니 부모 프로세스에서 여러 스레드를 두고 각 스레드가 proxy를 생성하는 것은 일반적인 사용 패턴은 아닌 것 같습니다.
아래와 같이 사용하는 경우는 없다고 보아야 하겠지요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namsic
parnet process에서 어떻게 함수를 호출할 지 모르기 때문에
lock을 두는 것은 유지하고,
locking 방식만 위의 코멘트에 제시한 방식대로 변경합시다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경했습니다.