FEATURE: Add multi-storage operations. #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
force-pushed
the
uhm0311/develop
branch
2 times, most recently
from
4cd9314
to
8d4551a
Compare
|
@uhm0311 CI ํ ์คํธ ํ์ธํ์ธ์. |
uhm0311
force-pushed
the
uhm0311/develop
branch
from
8d4551a
to
e8e028f
Compare
|
๋ฆฌ๋ทฐ ์์ํด์ฃผ์ธ์. |
namsic
approved these changes
Aug 21, 2024
jhpark816
reviewed
Aug 21, 2024
| test_success= false; | ||
| goto do_return; | ||
| } | ||
| else if (is_noreply == true) |
There was a problem hiding this comment.
is_noreply ์ฌ๋ถ์ ๊ด๊ณ์์ด ์๋์ madd ์ฌ์ํํ์ฌ ์คํจํ๋ ์ง๋ฅผ ํ์ธํ๋ฉด ๋์ง ์๋์ง ?
There was a problem hiding this comment.
noreply == true์ธ ๊ฒฝ์ฐ์๋ NOT_STORED๋ผ๋ ์๋ต์ ๋ฐ์ ์ ์๋๋ฐ ๋ฌด์์ ๊ฒ์ฆํด์ผ ํ๋์?
| goto do_return; | ||
| } | ||
|
|
||
| if (is_noreply == false) |
There was a problem hiding this comment.
์ฌ๊ธฐ๋ is_noreply ๊ด๊ณ์์ด mreplace ์ํ์ด ์คํจํ๋ ๊ฒ์ ํ์ธํ๋ฉด ๋์ง ์๋์ง?
๋ค๋ฅธ ํ ์คํธ์์๋ ๋ง์ฐฌ๊ฐ์ง์ ๋๋ค.
| @@ -78,19 +79,24 @@ static bool create_req(memcached_storage_request_st req[REQ_COUNT], bool value_p | |||
|
|
|||
| req[i].expiration= EXPIRE_TIME; | |||
| req[i].flags= (uint32_t) rand(); | |||
| req[i].cas= UINT64_MAX; | |||
There was a problem hiding this comment.
์ด ๊ฐ์ ์ค์ ํ๋ ์ด์ ๋ ๋ฌด์์ธ๊ฐ์?
There was a problem hiding this comment.
2๊ฐ์ง ์ด์ ์ ๋๋ค.
- mcas๊ฐ ์๋ ๊ฒฝ์ฐ, cas ๊ฐ์ด ์ค์ ๋์ด ์์ด๋ ๋ฌด์๋๋ ๊ฒ์ ๊ฒ์ฆ
- mcas์ธ ๊ฒฝ์ฐ, cas ๊ฐ์ด ์๋ฒ์ ์ ์ฅ๋ ๊ฐ๊ณผ ๋ค๋ฅผ ๋ EXISTS ์๋ต์ด ์ค๋ ๊ฒ์ ๊ฒ์ฆ
uhm0311
force-pushed
the
uhm0311/develop
branch
from
e8e028f
to
f86fa72
Compare
uhm0311
force-pushed
the
uhm0311/develop
branch
from
f86fa72
to
e32f0a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Related Issue
โจ๏ธ What I did