TEST: Split each step of the mset test code into functions. #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
force-pushed
the
uhm0311/develop
branch
7 times, most recently
from
f4c65d0
to
ab6a4f3
Compare
|
@uhm0311 CI ํ ์คํธ ํ์ธ ๋ฐ๋๋๋ค. |
uhm0311
force-pushed
the
uhm0311/develop
branch
from
ab6a4f3
to
720da3d
Compare
jhpark816
reviewed
Aug 20, 2024
| @@ -17,48 +17,55 @@ static inline void safe_free(void *ptr) | |||
| } | |||
| } | |||
|
|
|||
| static inline void safe_free_req(memcached_storage_request_st req[MSET_COUNT]) | |||
| static inline void safe_free_req(memcached_storage_request_st req[REQ_COUNT]) | |||
There was a problem hiding this comment.
safe_free_req() ํจ์์ ์ธ์๋ ์๋์ ๊ฐ์ด 2๊ฐ์ด์ด์ผ ํ์ง ์๋์?
safe_free_req(memcached_storage_request_st *req, int req_count)
{
for (int i= 0; i < req_count; i++)
{
}
}There was a problem hiding this comment.
๊ฐ์๊ฐ ํญ์ REQ_COUNT๋ก ์ ํด์ ธ ์์ผ๋ฏ๋ก ์๋ตํ์ต๋๋ค.
uhm0311
force-pushed
the
uhm0311/develop
branch
from
720da3d
to
8fd4d11
Compare
uhm0311
force-pushed
the
uhm0311/develop
branch
2 times, most recently
from
e8d4b26
to
384fa7f
Compare
namsic
approved these changes
Aug 20, 2024
uhm0311
force-pushed
the
uhm0311/develop
branch
from
384fa7f
to
22f2c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Related Issue
โจ๏ธ What I did
memcached_return_t๊ฐ ๊ฒ์ฆ