FEATURE: Add mset API. #294

uhm0311 · 2024-08-09T08:08:33Z

🔗 Related Issue

https://github.com/jam2in/arcus-works/issues/589

⌨️ What I did

~~기존 mget과 동일한 방식으로 사용할 수 있는 mset API를 추가합니다.~~
~~memcached_mset() 함수 호출 후 캐시 키 개수만큼 memcached_fetch_storage_result()를 호출하는 방식입니다.~~
mset 호출 시 요청을 일괄적으로 보낸 후에 응답을 일괄적으로 읽습니다.
madd, mreplace와 같은 기타 API는 추후에 추가할 예정입니다.

tests/storage

ing-eoking · 2024-08-11T23:56:19Z

tests/storage.cc

+
+using namespace libtest;
+
+#include "tests/storage.h"


테스트를 별도로 분리하는 것은 좋으나 지금은 Single storage 테스트 로직 주변에 위치시키는 것이 좋을 것 같습니다.

그런 다음 나중에 Storage 연산 테스트 전체를 별도 모듈로 옮기는 건 어떤가요?

mset 함수에 변경 사항이 있을 경우 개별 테스트는 계속 진행해야 하니 모든 변경 사항이 마무리된 후에 반영하겠습니다.

libmemcached/storage.cc

libmemcached/fetch.cc

ing-eoking · 2024-08-12T02:01:48Z

@namsic @jhpark816
리뷰 부탁드립니다.

namsic

일부 리뷰

libmemcached/storage.cc

jhpark816

일부 리뷰.

구현을 생각해 보니, 복잡한 요소가 존재하네요.

libmemcached/storage.cc

libmemcached/fetch.cc

libmemcached/storage.cc

jhpark816

일부 리뷰

libmemcached/storage.cc

libmemcached/memcached.cc

libmemcached/storage.cc

ing-eoking

아직 레플리케이션 쪽은 확인이 덜 되었습니다.

libmemcached/storage.cc

jhpark816

일부 리뷰

libmemcached/storage.cc

jhpark816

추가 리뷰

libmemcached/storage.cc

namsic · 2024-08-16T05:04:02Z

mset PR이 두 개인데, 둘 모두 각각 리뷰해야 하나요?

jhpark816 · 2024-08-16T05:07:26Z

@namsic
여기 PR만 리뷰하면 됩니다.

jhpark816

추가 리뷰

libmemcached/storage.cc

jhpark816 · 2024-08-16T05:30:00Z

추가 사항으로 number_of_req 값이 너무 크면, long query가 될 수 있습니다.
limit 지정하는 것이 어떤가요?

jhpark816

리뷰 완료

libmemcached/storage.cc

jhpark816

리뷰 완료

libmemcached/storage.cc

jhpark816 · 2024-08-16T08:40:19Z

@namsic 최종 리뷰하세요.

libmemcached/storage.cc

uhm0311 force-pushed the uhm0311/develop branch 3 times, most recently from 9f64858 to 3d1a64f Compare August 9, 2024 09:01

uhm0311 requested review from namsic and ing-eoking August 9, 2024 09:14

ing-eoking requested a review from jhpark816 August 11, 2024 23:46

This comment was marked as resolved.

Sign in to view

ing-eoking reviewed Aug 12, 2024

View reviewed changes

libmemcached/fetch.cc Outdated Show resolved Hide resolved

uhm0311 force-pushed the uhm0311/develop branch from 3d1a64f to 8ada7bf Compare August 12, 2024 01:29

uhm0311 requested a review from ing-eoking August 12, 2024 01:33

ing-eoking approved these changes Aug 12, 2024

View reviewed changes

namsic reviewed Aug 12, 2024

View reviewed changes

libmemcached/storage.cc Outdated Show resolved Hide resolved

libmemcached/storage.cc Outdated Show resolved Hide resolved

libmemcached/storage.cc Outdated Show resolved Hide resolved

libmemcached/storage.cc Outdated Show resolved Hide resolved

uhm0311 force-pushed the uhm0311/develop branch from 8ada7bf to 5aa0549 Compare August 12, 2024 04:07

jhpark816 reviewed Aug 12, 2024

View reviewed changes

uhm0311 force-pushed the uhm0311/develop branch 4 times, most recently from 9fa7443 to 719337e Compare August 12, 2024 09:17

jhpark816 reviewed Aug 12, 2024

View reviewed changes

libmemcached/storage.cc Show resolved Hide resolved

libmemcached/storage.cc Outdated Show resolved Hide resolved

jhpark816 reviewed Aug 12, 2024

View reviewed changes

libmemcached/storage.cc Outdated Show resolved Hide resolved

uhm0311 force-pushed the uhm0311/develop branch from 719337e to 93fb4d5 Compare August 13, 2024 05:40

uhm0311 requested review from namsic and ing-eoking August 13, 2024 05:43

uhm0311 force-pushed the uhm0311/develop branch from 93fb4d5 to c2d7588 Compare August 13, 2024 06:45

ing-eoking reviewed Aug 13, 2024

View reviewed changes

libmemcached/storage.cc Outdated Show resolved Hide resolved

libmemcached/storage.cc Outdated Show resolved Hide resolved

libmemcached/storage.cc Outdated Show resolved Hide resolved

jhpark816 requested a review from ing-eoking August 13, 2024 07:50

uhm0311 force-pushed the uhm0311/develop branch from c2d7588 to 9ff3643 Compare August 13, 2024 08:24

jhpark816 reviewed Aug 16, 2024

View reviewed changes

libmemcached/storage.cc Outdated Show resolved Hide resolved

libmemcached/storage.cc Outdated Show resolved Hide resolved

jhpark816 reviewed Aug 16, 2024

View reviewed changes

libmemcached/storage.cc Show resolved Hide resolved

uhm0311 force-pushed the uhm0311/develop branch 3 times, most recently from 68005f1 to 855ad4c Compare August 16, 2024 06:10

uhm0311 requested a review from jhpark816 August 16, 2024 06:20

jhpark816 reviewed Aug 16, 2024

View reviewed changes

libmemcached/storage.cc Outdated Show resolved Hide resolved

libmemcached/storage.cc Outdated Show resolved Hide resolved

uhm0311 force-pushed the uhm0311/develop branch 2 times, most recently from bb386e6 to 52ca5ed Compare August 16, 2024 06:57

uhm0311 requested a review from jhpark816 August 16, 2024 07:10

jhpark816 reviewed Aug 16, 2024

View reviewed changes

libmemcached/storage.cc Show resolved Hide resolved

libmemcached/storage.cc Show resolved Hide resolved

libmemcached/storage.cc Outdated Show resolved Hide resolved

libmemcached/storage.cc Outdated Show resolved Hide resolved

uhm0311 force-pushed the uhm0311/develop branch 2 times, most recently from 09a4d99 to e5be058 Compare August 16, 2024 07:33

uhm0311 requested a review from jhpark816 August 16, 2024 07:33

uhm0311 force-pushed the uhm0311/develop branch 2 times, most recently from 48147c6 to 8f55a92 Compare August 16, 2024 08:33

jhpark816 approved these changes Aug 16, 2024

View reviewed changes

uhm0311 force-pushed the uhm0311/develop branch from 8f55a92 to 9bb9d08 Compare August 16, 2024 08:42

namsic approved these changes Aug 16, 2024

View reviewed changes

jhpark816 reviewed Aug 16, 2024

View reviewed changes

libmemcached/storage.cc Outdated Show resolved Hide resolved

FEATURE: Add mset API.

e9437f7

uhm0311 force-pushed the uhm0311/develop branch from 9bb9d08 to e9437f7 Compare August 16, 2024 08:53

uhm0311 requested a review from jhpark816 August 16, 2024 08:53

jhpark816 merged commit 3dd6e1f into naver:develop Aug 16, 2024
1 check passed

uhm0311 mentioned this pull request Aug 19, 2024

FEATURE: Add mset API. #297

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FEATURE: Add mset API. #294

FEATURE: Add mset API. #294

uhm0311 commented Aug 9, 2024 •

edited

Loading

This comment was marked as resolved.

ing-eoking Aug 11, 2024 •

edited

Loading

uhm0311 Aug 12, 2024

ing-eoking commented Aug 12, 2024

namsic left a comment

jhpark816 left a comment

jhpark816 left a comment

ing-eoking left a comment

jhpark816 left a comment

jhpark816 left a comment

namsic commented Aug 16, 2024

jhpark816 commented Aug 16, 2024

jhpark816 left a comment

jhpark816 commented Aug 16, 2024

jhpark816 left a comment

jhpark816 left a comment

jhpark816 commented Aug 16, 2024

FEATURE: Add mset API. #294

FEATURE: Add mset API. #294

Conversation

uhm0311 commented Aug 9, 2024 • edited Loading

🔗 Related Issue

⌨️ What I did

This comment was marked as resolved.

ing-eoking Aug 11, 2024 • edited Loading

Choose a reason for hiding this comment

uhm0311 Aug 12, 2024

Choose a reason for hiding this comment

ing-eoking commented Aug 12, 2024

namsic left a comment

Choose a reason for hiding this comment

jhpark816 left a comment

Choose a reason for hiding this comment

jhpark816 left a comment

Choose a reason for hiding this comment

ing-eoking left a comment

Choose a reason for hiding this comment

jhpark816 left a comment

Choose a reason for hiding this comment

jhpark816 left a comment

Choose a reason for hiding this comment

namsic commented Aug 16, 2024

jhpark816 commented Aug 16, 2024

jhpark816 left a comment

Choose a reason for hiding this comment

jhpark816 commented Aug 16, 2024

jhpark816 left a comment

Choose a reason for hiding this comment

jhpark816 left a comment

Choose a reason for hiding this comment

jhpark816 commented Aug 16, 2024

uhm0311 commented Aug 9, 2024 •

edited

Loading

ing-eoking Aug 11, 2024 •

edited

Loading