Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Fix a smget handling about trimmed result without bkey #286

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ing-eoking
Copy link
Collaborator

@ing-eoking ing-eoking commented Mar 21, 2024

๐Ÿ”— Related Issue

  • jam2in/arcus-works#480

โŒจ๏ธ What I did

  • smget(new) ์—ฐ์‚ฐ ์‹œ VALUE ๊ฒฐ๊ณผ๊ฐ€ 0์ธ result์— ๋Œ€ํ•ด Trimmed Key ๋น„๊ต ์—ฐ์‚ฐ์„ ์ˆ˜ํ–‰ํ•˜์ง€ ์•Š๊ฒŒ ๋” ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์„œ๋ฒ„์—์„œ ๋ฐ›์€ ๋ชจ๋“  bkey type์— ๋Œ€ํ•ด ์‚ฌ์šฉ์ž๊ฐ€ ์ž…๋ ฅํ•œ bkey type๊ณผ ๋‹ค๋ฅผ ๊ฒฝ์šฐ PROTOCOL_ERROR๋ฅผ ๋ฐ˜ํ™˜ํ•˜๋„๋ก ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.
    • (๊ธฐ์กด) Value์—์„œ ๋ฐ›์€ element์˜ bkey type๊ณผ trimmed key์—์„œ์˜ bkey type์ด ๋‹ค๋ฅธ ๊ฒฝ์šฐ PROTOCOL_ERROR๋ฅผ ๋ฐ˜ํ™˜
  • ์ผ๋ถ€ uninitialized variable error๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿค” Others

  • ์„œ๋ฒ„์˜ Response ๋ฉ”์‹œ์ง€
    ELEMENTS 0
    MISSED_KEYS 0
    TRIMMED_KEYS 1
    b 201
    END
    
  • ๋ณ€๊ฒฝ๋œ ๋ฐ˜ํ™˜ ๊ฒฐ๊ณผ
    • ๊ธฐ์กด
    memcached smget(new) result : PROTOCOL ERROR, response : PROTOCOL ERROR
    
    • ๋ณ€๊ฒฝ
    memcached smget(new) result : SUCCESS, response : SERVER END
    

@ing-eoking ing-eoking marked this pull request as draft March 21, 2024 03:03
@ing-eoking ing-eoking self-assigned this Mar 21, 2024
@ing-eoking ing-eoking marked this pull request as ready for review March 26, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant