-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid.js Integration redux #3697
base: master
Are you sure you want to change the base?
Conversation
I never really paid much attention to the other PR, but now i see, does this allow for ruby to be interpreted in our brews? Could this cause a security issue? |
No, the ruby bit there was just an example that it doesn't break other code spaces... |
Yep, that's something to do with calculating the sizes of the element so the flow of text can be established before they're shown. Something to do with the auto-scaling that mermaid does. Test that by inserting a very long lorm ipsum string into an otherwise very brief mermaid doc.
Authors can change the A bit of good news is that A bug though is that the insertion of a semicolon This works on the mermaid.js test sandbox
but throws an error here... |
yeah I would classify this as “can’t be fixed with css” |
These issues may be due to things updated and/or fixed in later than the pinned version of mermaidjs. I was unable to persuade other versions to properly build as a marked plugin. If someone else with better node-fu can tackle it then maybe we should boot this back to draft until I can manage it. |
To be sure, is the mermaidjs version that this is relying on And latest mermaid as of this writing is |
Correct. Though I think I know how to resolve my previous issue now. If not, we're pinned there until the incompatibility between marked and marmaid 11.2.1 is resolved. |
Nope. Can't figure it out. Leaving it on the 9 branch so it works and waiting for someone smarter to figure out why the fais to find mermaid with 10 or later releases. |
Closes #2701
This is a slight rebuild of the orphaned mermaid PR #2740.
As such, from the body of that PR ...
The heavy lifting is done in the marked-mermaid package which I've open-sourced here:
https://github.com/MichielDeMey/marked-mermaid
This has been replaced by marked-mermaidjs which is an updated form of this package living at https://github.com/dbolack-ab/marked-mermaid
Example Homebrewery document: