Change BrewRenderer background in Heroku test deployments #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Ambatte
added
P3 - low priority
G-Ambatte
changed the title
|
What issue is this trying to solve? |
This is trying to help us in the development, so we don't confuse local vs deployment vs live. Minor inconveniences. |
|
Can we get a deployment on this one to validate? |
dbolack-ab
approved these changes
Sep 1, 2024
5e-Cleric
reviewed
Sep 1, 2024
dbolack-ab
approved these changes
Oct 4, 2024
|
@G-Ambatte Can you address 5e-Cleric's open comment and resolve conflicts, and then I can merge this. |
calculuschild
added
🔍 R3 - Reviewed - Awaiting Fixes 🔧
I've implemented the suggested change... which led me to investigate if |
calculuschild
approved these changes
Oct 11, 2024
|
Nice added cleanup. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the BrewRenderer to change the default background when the
HEROKU_APP_NAMEvariable exists. This variable only exists when created during the PR deployment process in Heroku apps, or when specifically set on a Development machine.The main purpose of this PR is to create a visual indication that someone is working on a deployment, NOT the main website. This is primarily intended to be a Dev Experience QoL improvement, which is why I've marked it as a low priority change.