server side concurrency #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It carries informations about a request when being handled server side. The goal is to simplify concurrency implementation
instead of calling it separately for each method
The unmarshalling is now done the same way it is done for other methods.
cdevienne
force-pushed
the
48-server-side-concurrency
branch
from
64aad3e
to
9f435ef
Compare
This function takes care of sending the reply after running the handler. To keep the prometheus metrics, a AfterReply callback was added on the request.
Closed
Handlers can optionnally be initialized with a WorkerPool that controls how many concurrent calls can be handled, and how many pending requests can be queued.
If a request is pending for more than the maxPendingDuration, the scheduler send a SERVERTOOBUSY to the caller. This way, an overloaded server will always reply something to the client, which reduces a lot the cases where it gets a timeout error. The maxPendingDuration should be short enough so that this duration plus the handling duration remains smaller than the client timeout. A next version of this system could cancel a running handler if its too long and send a reply 'server is too slow' to the client
|
I did a review with a colleague, and have a few more things to clean. Stay tuned. |
This saves a few more lines of generated code.
This is to be sure that scheduler() will never attempt to write to the schedule chan after its closed.
…ing tasks that the new queue size
…lf on RunAndReply
|
@mdevan I think I am done now. I will test the PR in my project this afternoon. |
|
Hi @mdevan |
mdevan
reviewed
Sep 19, 2018
cdevienne
force-pushed
the
48-server-side-concurrency
branch
from
8f49f70
to
58accd6
Compare
|
Thanks @mdevan for the detailed review. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #48.
The first 8 commits refactors the code in order to generate less code and simplify the concurrency implementation.
On side-effect is that a Request struct is now available in the context and provides access to all the request information.
The last commits implements concurrency.