Change Header::append value to IntoHeaderValue

nats-io · Aug 4, 2023 · c83badc · c83badc
1 parent ff7e1dd
commit c83badc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/async-nats/src/connection.rs b/async-nats/src/connection.rs
@@ -22,7 +22,7 @@ use tokio::io::{AsyncReadExt, AsyncWrite};
 use bytes::{Buf, BytesMut};
 use tokio::io;
 
-use crate::header::{HeaderMap, HeaderName};
+use crate::header::{HeaderMap, HeaderName, IntoHeaderValue};
 use crate::status::StatusCode;
 use crate::{ClientOp, ServerError, ServerOp};
 
@@ -304,7 +304,7 @@ impl Connection {
                 }
                 value.truncate(value.trim_end().len());
 
-                headers.append(name, value);
+                headers.append(name, value.into_header_value());
             }
 
             return Ok(Some(ServerOp::Message {

diff --git a/async-nats/src/header.rs b/async-nats/src/header.rs
@@ -139,17 +139,15 @@ impl HeaderMap {
     /// let mut headers = HeaderMap::new();
     /// headers.append("Key", "Value");
     /// headers.append("Key", "Another");
-    pub fn append<K: IntoHeaderName, V: ToString>(&mut self, name: K, value: V) {
+    pub fn append<K: IntoHeaderName, V: IntoHeaderValue>(&mut self, name: K, value: V) {
         let key = name.into_header_name();
         let v = self.inner.get_mut(&key);
         match v {
             Some(v) => {
-                v.push(HeaderValue {
-                    inner: value.to_string(),
-                });
+                v.push(value.into_header_value());
             }
             None => {
-                self.insert(key, value.to_string().into_header_value());
+                self.insert(key, value.into_header_value());
             }
         }
     }