Fix JS API deserializer #709
Merged
+228
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace JsonDocument-based responses with strongly-typed `NatsJSApiResult<T>` for improved type safety and error handling. Added new deserialization logic and tests to cover valid responses, errors, and edge cases like empty buffers.
mtmk
added
bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a serialization issue that was happening when interacting with JetStream APIs. Impact should be minimal since JetStream API calls would be retried in most cases however you might see warnings in your logs regarding malformed JSON buffers. The bug was introduced in v2.5.5.
Basically JsonDocument was handed a buffer which it accesses after the point where buffer is returned to the pool and overwritten with new data, while JsonDocument still reading it and causing JSON serialization exceptions.
Solution was to confine serialization with in the serializer and return an optional type
NatsJSApiResult<T>representing an API error type or the requested type.