Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the Windows Memory Tests #708

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Disable the Windows Memory Tests #708

merged 1 commit into from
Jan 8, 2025

Conversation

stebet
Copy link
Collaborator

@stebet stebet commented Jan 8, 2025

The Memory Tests seem to hang so let's skip them for now

@stebet stebet requested a review from mtmk January 8, 2025 16:11
mtmk
mtmk approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we can disable the memory tests until we find the reason so that rest of the functional tests can run on windows too

LGTM thanks @stebet

@mtmk mtmk merged commit af04c71 into nats-io:main Jan 8, 2025
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stebet @mtmk