Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KV Filtering of keys #545

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Add KV Filtering of keys #545

merged 7 commits into from
Jul 5, 2024

Conversation

darkwatchuk
Copy link
Contributor

@darkwatchuk darkwatchuk commented Jul 5, 2024

Resolves #521

@mtmk mtmk self-requested a review July 5, 2024 10:10
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @darkwatchuk

@mtmk mtmk merged commit 8e5493b into nats-io:main Jul 5, 2024
10 checks passed
@rickdotnet
Copy link
Collaborator

@mtmk , how important is this bit from the ADR? It looks as though it doesn't impact this implementation. Just making sure we don't need an additional check.

// When multiple filters are passed, client library should check `consumer info` from `consumer create method` if the filters are matching,
// as nats-server < 2.10 would ignore them.

@mtmk
Copy link
Collaborator

mtmk commented Jul 6, 2024

@mtmk , how important is this bit from the ADR? It looks as though it doesn't impact this implementation. Just making sure we don't need an additional check.

// When multiple filters are passed, client library should check `consumer info` from `consumer create method` if the filters are matching,
// as nats-server < 2.10 would ignore them.

@rickdotnet good point. created an issue for it:

mtmk added a commit that referenced this pull request Jul 6, 2024
* Full coverage kv management methods (#535)
* Remove unnecessary comment and configuration modification (#537)
* Unity il2cpp build fix (#543)
* Add KV Filtering of keys (#545)
* netstandard Nullable ref fix (#542)
* Fixed version number sent to server and changed lang to .NET from C#.… (#541)
@mtmk mtmk mentioned this pull request Jul 6, 2024
mtmk added a commit that referenced this pull request Jul 6, 2024
* Full coverage kv management methods (#535)
* Remove unnecessary comment and configuration modification (#537)
* Unity il2cpp build fix (#543)
* Add KV Filtering of keys (#545)
* netstandard Nullable ref fix (#542)
* Fixed version number sent to server and changed lang to .NET from C#.… (#541)
mtmk added a commit that referenced this pull request Jul 9, 2024
* Fix Unity il2cpp error (#548)
* Full coverage kv management methods (#535)
* Remove unnecessary comment and configuration modification (#537)
* Add KV Filtering of keys (#545)
* netstandard Nullable ref fix (#542)
* Fixed version number sent to server and changed lang to .NET from C#.… (#541)
@mtmk mtmk mentioned this pull request Jul 9, 2024
mtmk added a commit that referenced this pull request Jul 9, 2024
* Fix Unity il2cpp error (#548)
* Full coverage kv management methods (#535)
* Remove unnecessary comment and configuration modification (#537)
* Add KV Filtering of keys (#545)
* netstandard Nullable ref fix (#542)
* Fixed version number sent to server and changed lang to .NET from C#.… (#541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filtering to KV method returning all keys
3 participants