Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] microService_AddEndpoint() could crash if subject is invalid #831

Merged
merged 1 commit into from
Jan 15, 2025

[FIXED] microService_AddEndpoint() could crash if subject is invalid

d1df7ee
Select commit
Loading
Failed to load commit list.
Merged

[FIXED] microService_AddEndpoint() could crash if subject is invalid #831

[FIXED] microService_AddEndpoint() could crash if subject is invalid
d1df7ee
Select commit
Loading
Failed to load commit list.
Travis CI / Travis CI - Branch succeeded Jan 13, 2025 in 5m 54s

Build Passed

The build passed. This is a change from the previous build, which failed.

Details

This is a normal build for the fix_use_after_free branch. You should be able to reproduce it by checking out the branch locally.

Jobs and Stages

This build has 12 jobs, running in parallel.

Job Compiler ENV OS State
2885.1 gcc DO_COVERAGE="coverage" BUILD_OPT="-DNATS_COVERAGE=ON -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Debug -DNATS_BUILD_TLS_USE_OPENSSL_1_1_API=ON" Linux passed
2885.2 clang DO_COVERAGE="coverage" BUILD_OPT="-DNATS_COVERAGE=ON -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Debug -DNATS_BUILD_TLS_USE_OPENSSL_1_1_API=ON" Linux passed
2885.3 NATS server - latest release gcc NATS_TEST_SERVER_VERSION=latest Linux passed
2885.4 NATS server - main gcc NATS_TEST_SERVER_VERSION=main Linux passed
2885.5 gcc-9 - TLS OFF gcc NATS_TEST_SERVER_VERSION=main Linux passed
2885.6 gcc-9 - Streaming OFF gcc MATRIX_EVAL="CC=gcc-9" Linux passed
2885.7 gcc-9 - Default - sanitize address gcc NATS_TEST_SERVER_VERSION=main Linux passed
2885.8 gcc-9 - Lib msg delivery - sanitize address gcc NATS_TEST_SERVER_VERSION=main Linux passed
2885.9 gcc-9 - Write deadline - sanitize address gcc NATS_TEST_SERVER_VERSION=main Linux passed
2885.10 clang-8 - TLS OFF clang MATRIX_EVAL="CC=clang-8" Linux passed
2885.11 clang-8 - Default - sanitize address clang NATS_TEST_SERVER_VERSION=main Linux passed
2885.12 clang-8 - Default - sanitize thread clang NATS_TEST_SERVER_VERSION=main Linux passed

Build Configuration

Build Option Setting
Language C++
Operating System Linux (Focal)
Compiler Versions gcc, clang
Build Configuration
{
  "language": "cpp",
  "os": [
    "linux"
  ],
  "dist": "focal",
  "cache": {
    "directories": [
      "$HOME/deps"
    ]
  },
  "compiler": [
    "gcc",
    "clang"
  ],
  "before_install": [
    "bash install_deps.sh",
    "if [ \"$DO_COVERAGE\" = \"coverage\" ]; then pip install --user cpp-coveralls; fi",
    "eval \"${MATRIX_EVAL}\""
  ],
  "before_script": [
    "export PATH=$HOME/deps/cmake-install:$HOME/deps/cmake-install/bin:$HOME/deps/nats-server:$HOME/deps/nats-streaming-server:$PATH",
    "mkdir build && cd build"
  ],
  "env": [
    "jobs={:DO_COVERAGE=>\"\\\"coverage\\\"\", :BUILD_OPT=>\"\\\"-DNATS_COVERAGE=ON -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Debug -DNATS_BUILD_TLS_USE_OPENSSL_1_1_API=ON\\\"\"}"
  ],
  "jobs": {
    "include": [
      {
        "name": "NATS server - latest release",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "NATS_TEST_SERVER_VERSION": "latest"
          },
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release\"",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "NATS server - main",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "NATS_TEST_SERVER_VERSION": "main"
          },
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release\"",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "gcc-9 - TLS OFF",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "NATS_TEST_SERVER_VERSION": "main"
          },
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_WITH_TLS=OFF -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release\"",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "gcc-9 - Streaming OFF",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_STREAMING=OFF -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release\"",
            "DO_COVERAGE": "\"no\"",
            "CTEST_OPT": "\"-I 1,1\""
          }
        ]
      },
      {
        "name": "gcc-9 - Default - sanitize address",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "NATS_TEST_SERVER_VERSION": "main"
          },
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS=-fsanitize=address\"",
            "NATS_TEST_VALGRIND": "yes",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "gcc-9 - Lib msg delivery - sanitize address",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "NATS_TEST_SERVER_VERSION": "main"
          },
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "NATS_DEFAULT_TO_LIB_MSG_DELIVERY": "yes",
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS=-fsanitize=address\"",
            "NATS_TEST_VALGRIND": "yes",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "gcc-9 - Write deadline - sanitize address",
        "compiler": "gcc",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "ubuntu-toolchain-r-test"
              },
              {
                "sourceline": "ppa:ubuntu-toolchain-r/test"
              }
            ],
            "packages": [
              "g++-9"
            ]
          }
        },
        "env": [
          {
            "NATS_TEST_SERVER_VERSION": "main"
          },
          {
            "MATRIX_EVAL": "\"CC=gcc-9\""
          },
          {
            "NATS_DEFAULT_LIB_WRITE_DEADLINE": "2000",
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS=-fsanitize=address\"",
            "NATS_TEST_VALGRIND": "yes",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "clang-8 - TLS OFF",
        "compiler": "clang",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "llvm-toolchain-xenial-8"
              }
            ],
            "packages": [
              "clang-8"
            ]
          }
        },
        "env": [
          {
            "MATRIX_EVAL": "\"CC=clang-8\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_WITH_TLS=OFF -DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release\"",
            "DO_COVERAGE": "\"no\"",
            "CTEST_OPT": "\"-I 1,1\""
          }
        ]
      },
      {
        "name": "clang-8 - Default - sanitize address",
        "compiler": "clang",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "llvm-toolchain-xenial-8"
              }
            ],
            "packages": [
              "clang-8"
            ]
          }
        },
        "env": [
          {
            "NATS_TEST_SERVER_VERSION": "main"
          },
          {
            "MATRIX_EVAL": "\"CC=clang-8\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS=-fsanitize=address\"",
            "NATS_TEST_VALGRIND": "yes",
            "DO_COVERAGE": "\"no\""
          }
        ]
      },
      {
        "name": "clang-8 - Default - sanitize thread",
        "compiler": "clang",
        "addons": {
          "apt": {
            "sources": [
              {
                "name": "llvm-toolchain-xenial-8"
              }
            ],
            "packages": [
              "clang-8"
            ]
          }
        },
        "env": [
          {
            "NATS_TEST_SERVER_VERSION": "main"
          },
          {
            "MATRIX_EVAL": "\"CC=clang-8\""
          },
          {
            "BUILD_OPT": "\"-DNATS_BUILD_ARCH=64 -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_C_FLAGS=-fsanitize=thread\"",
            "NATS_TEST_VALGRIND": "yes",
            "DO_COVERAGE": "\"no\""
          }
        ]
      }
    ]
  },
  "script": [
    "$TRAVIS_BUILD_DIR/buildOnTravis.sh \"$CC\" \"$DO_COVERAGE\" \"$BUILD_OPT -DNATS_SANITIZE=ON -DNATS_BUILD_TLS_USE_OPENSSL_1_1_API=ON -DNATS_PROTOBUF_DIR=$HOME/deps/pbuf -DNATS_BUILD_USE_SODIUM=ON -DNATS_SODIUM_DIR=$HOME/deps/sodium\" \"$CTEST_OPT\""
  ],
  "after_success": [
    "cd ..",
    "if [[ \"$DO_COVERAGE\" == \"coverage\" && \"$TRAVIS_COMPILER\" == \"gcc\" ]]; then coveralls --gcov-options '\\-lp' -r . -i \"src/\" -e \"src/win/\" -e \"src/unix/\" -e \"src/stan/protocol.pb-c.c\" -E \".*\\.h$\"; fi"
  ],
  "notifications": {
    "email": [
      {
        "enabled": false
      }
    ]
  }
}